Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal: v1.4.0 #932

Closed
rvagg opened this issue Feb 23, 2015 · 77 comments
Closed

Release proposal: v1.4.0 #932

rvagg opened this issue Feb 23, 2015 · 77 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@rvagg
Copy link
Member

rvagg commented Feb 23, 2015

Can anybody see a semver-major in here that's not properly tagged? If not, let's go and get a patch release out within the next day or two.

  • [8a1e22af3a] - benchmark: pass execArgv to the benchmarking process (Petka Antonov) #928
  • [234e6916b8] - build: Fix incorrect reference (Johan Bergström) #924
  • [e00c938d24] - build: make test-ci output TAP to stdout and log (Rod Vagg) #938
  • [b2a0d8f65e] - deps: update libuv to 1.4.2 (Ben Noordhuis) #966
  • [a558cd0a61] - deps: revert v8 abi change (Ben Noordhuis) #952
  • [54532a9761] - deps: fix postmortem support in v8 (Fedor Indutny) #706
  • [78f4837926] - deps: upgrade v8 to 4.1.0.21 (Ben Noordhuis) #952
  • [739fda16a9] - deps: update libuv to 1.4.1 (Ben Noordhuis) #940
  • [da730c76e9] - deps: enable node-gyp iojs.lib download checksum (Ben Noordhuis) #918
  • [97b424365a] - deps: make node-gyp work again on windows (Bert Belder)
  • [19e3d5e10a] - deps: make node-gyp fetch tarballs from iojs.org (Ben Noordhuis) #343
  • [1e2fa1537f] - deps: upgrade npm to 2.6.0 (Forrest L Norvell) #904
  • [2e63bad7eb] - doc: link & formatting of SHAs in commit list (Tim Oxley) #967
  • [c5050d8e4d] - doc: fix 'dhparam' description of tls.createServer (silverwind) #968
  • [06ee782f24] - doc: document 'unhandledRejection' and 'rejectionHandled' (Benjamin Gruenbaum) #946
  • [b65dade102] - doc: update documentation.markdown for io.js. (Ryan Scheel) #950
  • [87e4bfd582] - doc: link cluster worker.send() to child.send() (Sam Roberts) #839
  • [cb22bc9b8a] - doc: fix footer sizing (Jeremiah Senkpiel) #860
  • [3ab9b92e90] - doc: fix stream _writev header size (René Kooi) #916
  • [4fcbb8aaaf] - doc: use HTTPS URL for the API documentation page (Shinnosuke Watanabe) #913
  • [329f364ea2] - doc: fix PR reference in CHANGELOG (Brian White) #903
  • [0ac57317aa] - doc: fix typo, rephrase cipher change in CHANGELOG (Rod Vagg) #902
  • [1f40b2a636] - fs: add type checking to makeCallback() (cjihrig) #866
  • [c82e580a50] - fs: properly handle fd passed to truncate() (Bruno Jouhier) joyent/node#9161
  • [2ca22aacbd] - (SEMVER-MINOR) http: emit abort event from ClientRequest (Evan Lucas) #945
  • [d8eb974a98] - net: make Server.prototype.unref() persistent (cjihrig) #897
  • [872702d9b7] - (SEMVER-MINOR) node: implement unhandled rejection tracking (Petka Antonov) #758
  • [b41dbc2737] - readline: use native codePointAt (Vladimir Kurchatkin) #825
  • [26ebe9805e] - smalloc: extend user API (Trevor Norris) #905
  • [e435a0114d] - src: fix intermittent SIGSEGV in resolveTxt (Evan Lucas) #960
  • [0af4c9ea74] - src: fix domains + --abort-on-uncaught-exception (Chris Dickinson) #922
  • [89e133a1d8] - stream_base: remove static JSMethod declarations (Fedor Indutny) #957
  • [b9686233fc] - stream_base: introduce StreamBase (Fedor Indutny) #840
  • [1738c77835] - (SEMVER-MINOR) streams: introduce StreamWrap and JSStream (Fedor Indutny) #926
  • [506c7fd40b] - test: fix infinite spawn cycle in stdio test (Ben Noordhuis) #948
  • [a7bdce249c] - test: support writing test output to file (Johan Bergström) #934
  • [0df54303c1] - test: common.js -> common (Brendan Ashworth) #917
  • [ed3b057e9f] - util: handle symbols properly in format() (cjihrig) #931
@benjamingr
Copy link
Member

It'd be mighty swell to land #758 now that bnoordhuis and trevnorris LGTM'd it :D

@mscdex
Copy link
Contributor

mscdex commented Feb 24, 2015

And #847 ;-)

@rvagg
Copy link
Member Author

rvagg commented Feb 24, 2015

yes, it would be nice to land both of them, and others.. I'd like #894 to be fixed for instance.

But, we need to set and maintain a more rapid release cycle and avoid the mindset that releases should be held up to get particular things in--both for the sake of getting a release out and for the sake of making sure we take care before merging things that probably need further discussion.

Just remember that it'll likely be under a week after merging that your favourite pull request is finally merged, this ain't no 0.12.

@chrisdickinson
Copy link
Contributor

This all LGTM.

@Qard
Copy link
Member

Qard commented Feb 24, 2015

LGTM. :shipit:

@mikeal
Copy link
Contributor

mikeal commented Feb 24, 2015

+1

1 similar comment
@Fishrock123
Copy link
Contributor

+1

@rvagg
Copy link
Member Author

rvagg commented Feb 24, 2015

aaaactually, npm@2.6.0 is a minor version bump, does anybody have objections to bumping minor when npm bumps minor? see discussion @ #904 (comment) @iojs/tc

that would make this 1.4.0

@indutny
Copy link
Member

indutny commented Feb 24, 2015

@rvagg let's land #926 as it compliments StreamBase a lot.

@rvagg
Copy link
Member Author

rvagg commented Feb 24, 2015

@indutny sounds like you have a LGTM from Chris so go for it, just make sure you tag it if it's supposed to be semver-minor, we're programatically relying on those tags now

@indutny
Copy link
Member

indutny commented Feb 24, 2015

@rvagg there is also a security update in libuv that will happen today.

@indutny
Copy link
Member

indutny commented Feb 24, 2015

@rvagg libuv/libuv#222

@indutny
Copy link
Member

indutny commented Feb 24, 2015

@rvagg On other hand if @saghul won't be around - it should not block us.

@rvagg rvagg changed the title Release proposal: v1.3.1 Release proposal: v1.4.0 Feb 24, 2015
@rvagg
Copy link
Member Author

rvagg commented Feb 24, 2015

updated original description with newer changelog including SEMVER-MINOR tag for npm

@Fishrock123
Copy link
Contributor

As per discussion in #904, i'm not convinced this should be semver-minor as it currently stands.

@indutny
Copy link
Member

indutny commented Feb 24, 2015

@Fishrock123 semver-major?

@bnoordhuis
Copy link
Member

LGTM. I don't think the npm upgrade merits bumping the minor, for the reasons outlined in #904.

@indutny
Copy link
Member

indutny commented Feb 24, 2015

It doesn't but JSStream thing most likely does.

@indutny
Copy link
Member

indutny commented Feb 24, 2015

@rvagg libuv/libuv@e19089f , libuv will be released soon.

@indutny
Copy link
Member

indutny commented Feb 24, 2015

#926 landed in 1738c77, @rvagg : only libuv update is left (on my plate)

@indutny
Copy link
Member

indutny commented Feb 24, 2015

@rvagg please update to libuv 1.4.1 before the release.

@saghul
Copy link
Member

saghul commented Feb 24, 2015

I'll send a PR with the update.

@bnoordhuis
Copy link
Member

@saghul Beat you: #940 :-)

@saghul
Copy link
Member

saghul commented Feb 24, 2015

:-) We should coordinate that somehow...

@bnoordhuis
Copy link
Member

Sorry, I didn't want to flood your inbox. I'll cc you next time.

@saghul
Copy link
Member

saghul commented Feb 24, 2015

No worries Ben, and thanks!

@rvagg
Copy link
Member Author

rvagg commented Feb 25, 2015

Release blocked until #946 (or similar). I shouldn't have merged #256 without docs so it's my fault.

@benjamingr
Copy link
Member

@rvagg I've amended the docs PR based on domenic's and sam's criticism and comments :)

@rvagg
Copy link
Member Author

rvagg commented Feb 26, 2015

Yes, the build machines have inconsistent git tree now anyway so to be sure we'll do 1.4.1.

@saghul
Copy link
Member

saghul commented Feb 26, 2015

1.4.2 is out now. @bnoordhuis can you make the libuv update PR?

@jbergstroem
Copy link
Member

For future releases: how about setting a proposed release date so everyone know what timespan is expected for feedback? I guess the date/time would be relative to how "major" a release would be; spanning days, weeks or just hours.

@indutny
Copy link
Member

indutny commented Feb 26, 2015

@jbergstroem seems to be hard to predict, assuming that we don't have "definite" roadmap at this point.

@jbergstroem
Copy link
Member

@indutny hard to predict: valid point -- but suggesting a release date at the same time a changelog is posted gives a pretty good indication in terms of expected feedback. For reference, @rvagg suggested a release "within a day or two" three days ago. If that was a set date people might have acted differently.

@indutny
Copy link
Member

indutny commented Feb 26, 2015

Aaah, I thought you was talking about release dates in general. Ok, then.

@jbergstroem
Copy link
Member

@indutny Ah, not at all. In time, using milestones or whatnot is probably great. For now, it's not helping anyone.

@rvagg
Copy link
Member Author

rvagg commented Feb 26, 2015

2015-02-26, Version 1.4.1, @rvagg

Note: version 1.4.0 was tagged and built but not released. A libuv bug was discovered in the process so the release was aborted. The tag was straight after a558cd0a61 but has since been removed. We have jumped to 1.4.1 to avoid confusion.

Notable changes

  • process / promises: An'unhandledRejection' event is now emitted on process whenever a Promise is rejected and no error handler is attached to the Promise within a turn of the event loop. A 'rejectionHandled' event is now emitted whenever a Promise was rejected and an error handler was attached to it later than after an event loop turn. See the process documentation for more detail. #758 (Petka Antonov)
  • streams: you can now use regular streams as an underlying socket for tls.connect() #926 (Fedor Indutny)
  • http: A new 'abort' event emitted when a http.ClientRequest is aborted by the client. #945 (Evan Lucas)
  • V8: Upgrade V8 to 4.1.0.21. Includes an embargoed fix, details should be available at https://code.google.com/p/chromium/issues/detail?id=430201 when embargo is lifted. A breaking ABI change has been held back from this upgrade, possibly to be included when io.js merges V8 4.2. See #952 for discussion.
  • npm: Upgrade npm to 2.6.0. Includes features to support the new registry and to prepare for npm@3. See npm CHANGELOG.md for details. Summary:
    • 38c4825 #5068 Add new logout command, and make it do something useful on both bearer-based and basic-based authed clients. (@othiym23)
    • c8e08e6 #6565 Warn that peerDependency behavior is changing and add a note to the docs. (@othiym23)
    • 7c81a5f #7171 Warn that engineStrict in package.json will be going away in the next major version of npm (coming soon!) (@othiym23)
  • libuv: Upgrade to 1.4.2. See libuv ChangeLog for details of fixes.

Known issues

  • Surrogate pair in REPL can freeze terminal #690
  • Not possible to build io.js as a static library #686
  • process.send() is not synchronous as the docs suggest, a regression introduced in 1.0.2, see #760 and fix in #774
  • Calling dns.setServers() while a DNS query is in progress can cause the process to crash on a failed assertion #894

Commits

@rvagg
Copy link
Member Author

rvagg commented Feb 26, 2015

@rvagg
Copy link
Member Author

rvagg commented Feb 26, 2015

nightly / RC: https://jenkins-iojs.nodesource.com/job/iojs+release+nightly/92/

should be at https://iojs.org/download/nightly/v1.3.1-nightly201502262e2cf81476/ within 15 minutes or so, would appreciate testers before we release

@rvagg
Copy link
Member Author

rvagg commented Feb 26, 2015

release build for v1.4.1 @ https://jenkins-iojs.nodesource.com/job/iojs+release/28/

@mgol
Copy link
Contributor

mgol commented Feb 26, 2015 via email

@rvagg
Copy link
Member Author

rvagg commented Feb 26, 2015

take 2, problem with one of the windows build machines, crossing fingers it'll be taken care of automatically: https://jenkins-iojs.nodesource.com/job/iojs+release/29/

@rvagg
Copy link
Member Author

rvagg commented Feb 26, 2015

You're right @mzgol thanks for pointing that out. I'm going to get in to that machine and clean it out, that's not right.. Another reason we need to wean our way off Jenkins eventually.

@rvagg
Copy link
Member Author

rvagg commented Feb 26, 2015

problem on build machines is related to the aborted commit and my force push + delete of the 1.4.0 tag. I've set up the release job to clean & force a fresh clone before building, which is probably the best way to do release builds anyway. Looking good now @ https://jenkins-iojs.nodesource.com/job/iojs+release/31/

ARMv6 pending

@rvagg
Copy link
Member Author

rvagg commented Feb 26, 2015

nope, something still borked on the git end, shaving yaks, send help if I'm not back soon

@mgol
Copy link
Contributor

mgol commented Feb 26, 2015

@rvagg
Copy link
Member Author

rvagg commented Feb 26, 2015

I believe I finally have it sorted .. 2 hours later .. https://jenkins-iojs.nodesource.com/job/iojs+release/41/

@rvagg
Copy link
Member Author

rvagg commented Feb 26, 2015

just testing the builds before release, I don't have a high degree of trust at the moment thanks to Jenkins

@rvagg
Copy link
Member Author

rvagg commented Feb 26, 2015

all done & released, https://iojs.org/dist/latest/ has v1.4.1

ping @iojs/website

@rvagg rvagg closed this as completed Feb 26, 2015
@Fishrock123
Copy link
Contributor

Noted.

@benjamingr
Copy link
Member

Nice work @rvagg :)

@popomore
Copy link
Contributor

V8 has been back to 4.1.0.16, why still write 4.1.0.21 in changelog?

@bnoordhuis
Copy link
Member

@popomore What do you mean?

$ iojs -p '`io.js ${process.versions.node} ships V8 ${process.versions.v8}`'
io.js 1.4.2 ships V8 4.1.0.21

@popomore
Copy link
Contributor

Maybe I misunderstood the message from the commit bnoordhuis@a558cd0

@bnoordhuis
Copy link
Member

Ah, the 'backs out' refers to the change from the 4.1.0.16 release. That commit is essentially an upgrade to 4.1.0.21 minus the change that prompted the 4.1.0.16 release.

@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests