Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with test-cluster-disconnect-handles.js #3907

Closed
imran-iq opened this issue Nov 18, 2015 · 3 comments
Closed

Issue with test-cluster-disconnect-handles.js #3907

imran-iq opened this issue Nov 18, 2015 · 3 comments
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.

Comments

@imran-iq
Copy link
Contributor

There is currently an issue with the test test-cluster-disconnect-handles.js where the debugger gets an EADDRINUSE error and does not exit and therefore does not release the port it is using. This causes an issue when running

tools/test.py --mode=release --progress=tap parallel

As the port is not released and tests continue to run causing a large number of tests to fail with EADDRINUSE too.

Sample output:

imran@tp-iqbali ~/node/node_main ./out/Release/node --debug=12346. --expose_internals test/parallel/test-cluster-disconnect-handles.js
Debugger listening on port 12346
Error: listen EADDRINUSE :::12346
    at Object.exports._errnoException (util.js:915:11)
    at exports._exceptionWithHostPort (util.js:938:20)
    at Agent.Server._listen2 (net.js:1236:14)
    at listen (net.js:1272:10)
    at Agent.Server.listen (net.js:1369:5)
    at Object.start (_debug_agent.js:21:9)
    at startup (node.js:72:9)
    at node.js:976:3
(Process stays running until explicitly killed)

Output from lsof before running the test:

imran@tp-iqbali ~ lsof -i :12346
imran@tp-iqbali ~ 

And after

imran@tp-iqbali ~ lsof -i :12346
COMMAND   PID  USER   FD   TYPE    DEVICE SIZE/OFF NODE NAME
node    21680 imran   14u  IPv6 601170720      0t0  TCP *:12346 (LISTEN)
imran@tp-iqbali ~ ps aux | grep 21680
imran    21680  0.5  0.1 1343652 24012 pts/40  Sl+  16:37   0:00 ./out/Release/node --debug=12346. --expose_internals test/parallel/test-cluster-disconnect-handles.js
imran    22063  0.0  0.0  15940   956 pts/39   S+   16:38   0:00 grep --color=auto --exclude-dir=.bzr --exclude-dir=CVS --exclude-dir=.git --exclude-dir=.hg --exclude-dir=.svn 21680
imran@tp-iqbali ~ 

Making sure I have no running node instances before running the test

imran@tp-iqbali ~ ps -ef | grep node                                                                                                                                                                    
imran    21499 18732  0 16:37 pts/38   00:00:00 grep --color=auto --exclude-dir=.bzr --exclude-dir=CVS --exclude-dir=.git --exclude-dir=.hg --exclude-dir=.svn node

And after running the test

imran@tp-iqbali ~ ps -ef | grep node
imran    21680 18816  2 16:37 pts/40   00:00:00 ./out/Release/node --debug=12346. --expose_internals test/parallel/test-cluster-disconnect-handles.js
imran    21692 21680  1 16:37 pts/40   00:00:00 /home/imran/node/node_main/out/Release/node --debug=12346. /home/imran/node/node_main/test/parallel/test-cluster-disconnect-handles.js
imran    21779 18732  0 16:37 pts/38   00:00:00 grep --color=auto --exclude-dir=.bzr --exclude-dir=CVS --exclude-dir=.git --exclude-dir=.hg --exclude-dir=.svn node
imran@tp-iqbali ~ 

I have ran into this issue on multiple machines.

This is on linux x86-64, with e4e5b13 checked out from master branch

Using ubuntu 14.04
output of uname -a

Linux tp-iqbali 3.13.0-53-generic #89-Ubuntu SMP Wed May 20 10:34:39 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
@mscdex mscdex added cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. labels Nov 18, 2015
@jelmd
Copy link

jelmd commented Nov 19, 2015

Same here on S11.3 with v5.1.0

@imran-iq
Copy link
Contributor Author

Issue is fixed by simply not specifying --debug on the command line

imran@tp-iqbali ~/node/node_main ./out/Debug/node  --expose_internals test/parallel/test-cluster-disconnect-handles.js
imran@tp-iqbali ~/node/node_main

@imran-iq
Copy link
Contributor Author

imran-iq commented Dec 4, 2015

Issue seems to be fixed with #4009 and #4084 closing issue

@imran-iq imran-iq closed this as completed Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

3 participants