Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Chromium:666046 for Node 6.x #21389

Closed
ofrobots opened this issue Jun 18, 2018 · 7 comments
Closed

Backport Chromium:666046 for Node 6.x #21389

ofrobots opened this issue Jun 18, 2018 · 7 comments
Labels
help wanted Issues that need assistance from volunteers or PRs that need help to proceed. v8 engine Issues and PRs related to the V8 dependency.

Comments

@ofrobots
Copy link
Contributor

ofrobots commented Jun 18, 2018

Chromium:666046 is a bug known to affect Node 6.x. A fix is available that needs to be back-ported to Node 6.x.

For full details on how we manage the V8 branches in Node release lines see this doc.

@ofrobots ofrobots added help wanted Issues that need assistance from volunteers or PRs that need help to proceed. v8 engine Issues and PRs related to the V8 dependency. labels Jun 18, 2018
@ofrobots
Copy link
Contributor Author

ofrobots commented Jun 18, 2018

/cc @codebytere as you were interested in helping out. This fix itself looks small enough so hopefully the back-port isn't tremendously complicated. I'd be happy to help if you get stuck.

@codebytere
Copy link
Member

@ofrobots thanks, i'll take a stab at it!

@vitkarpov
Copy link
Contributor

vitkarpov commented Jun 23, 2018

@codebytere seems for me like it's a good change to contribute, isn't it? Are you going to do this or I can take it? (and ping you for a review if you'd like)

@vitkarpov
Copy link
Contributor

vitkarpov commented Jun 23, 2018

Oh, it's already been done:

and landed a while ago. It's weird that this issue seems fresh and the chromium issue doesn't have any updates about it.

@codebytere
Copy link
Member

@vitkarpov oh you're right, bummer but glad it's been taken care of!

@vitkarpov
Copy link
Contributor

Anything else which could be taken care of? ;) Looking for another issue.

@ofrobots
Copy link
Contributor Author

@vitkarpov thanks a lot for taking a look. My bad for losing track of the issue already being fixed in Node 😬. I've updated the chromium issue. There are few more issues I am planning to open next week for potential backports, keep an eye on the 'V8 Engine' and 'help wanted' labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues that need assistance from volunteers or PRs that need help to proceed. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests

3 participants