source <(npm completion) doesn't end in Node v10.4.0

[teppeis]

• Version: v10.4.0
• Platform: Darwin Kernel Version 17.5.0: Fri Apr 13 19:32:32 PDT 2018; root:xnu-4570.51.2~1/RELEASE_X86_64 x86_64
• Subsystem:

In bash or zsh, following command doesn't end in Node v10.4.0.

$ cat <(node -v)
v10.4.0

Because of this change, source <(npm completion) in my .zshrc stops initializing a new shell.

In Node v10.3.0, the command ends normally.

[addaleax]

This was most likely caused by c2c9c0c /cc @bnoordhuis @tabkrz

Fwiw, for me this fails with:

./node[4191]: ../src/node.cc:3791:void node::PlatformExit(): Assertion `(err) != (-1)' failed.
v11.0.0-pre

The relevant strace line is

ioctl(0, SNDCTL_TMR_START or TCSETS, {B38400 opost isig icanon echo ...}) = -1 EIO (Input/output error)

[evanlucas]

I just noticed this as well. Opened a revert PR at (#21257)

[ktaborski]

Was someone able to reproduce this on another platform? I can not reproduce this on my RedHat7.

[addaleax]

Yes, that crash above is on a Ubuntu 17.10 machine.

[evgenymarkov]

Same issue. I'm just calling process.exit() and node shows me stacktrace. This bug occurs in 10.4, but not in 10.3.

Platform: Darwin hellroot 17.6.0 Darwin Kernel Version 17.6.0: Tue May 8 15:22:16 PDT 2018; root:xnu-4570.61.1~1/RELEASE_X86_64 x86_64

[teppeis]

Fixed in v10.4.1
Thank you! 😄