Flaky test-net-connect-local-error

[BridgeAR]

https://ci.nodejs.org/job/node-test-commit-freebsd/15207/nodes=freebsd11-x64/console

not ok 2100 sequential/test-net-connect-local-error
  ---
  duration_ms: 0.233
  severity: fail
  stack: |-
    assert.js:74
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: undefined strictEqual 12347
        at Socket.onError (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/sequential/test-net-connect-local-error.js:18:10)
        at Socket.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/common/index.js:475:15)
        at Socket.emit (events.js:131:13)
        at emitErrorNT (internal/streams/destroy.js:64:8)
        at process._tickCallback (internal/process/next_tick.js:91:19)
  ...

[apapirovski]

Presumably it's hitting this path:

node/lib/net.js

Lines 975 to 985 in 6963a93

	if (err) {
	var sockname = self._getsockname();
	var details;
	if (sockname) {
	details = sockname.address + ':' + sockname.port;
	}
	const ex = exceptionWithHostPort(err, 'connect', address, port, details);
	self.destroy(ex);
	}

Instead of the one it's supposed to (afterConnect).

Anyone from @nodejs/http have any insights?

[BridgeAR]

And again https://ci.nodejs.org/job/node-test-commit-freebsd/nodes=freebsd11-x64/17105/console

[apapirovski]

If I had to guess, this failure is related to the FreeBSD "jail" in our common file. It's failing before it even gets past the lookup which means it's failing on the IPv4 address. It's possible the process.env.LOCALHOST is set to something weird or something else strange happens? The fact that this only fails occasionally is rather confusing.