Skip to content

Commit

Permalink
policy: fix message for invalid manifest specifier
Browse files Browse the repository at this point in the history
Add test for invalid manifest specifier and fix the error message
which is missing a space ("singletrailing" instead of
"single trailing").

PR-URL: #40574
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
  • Loading branch information
Trott authored and BethGriggs committed Nov 24, 2021
1 parent 2700909 commit dab574e
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 3 deletions.
5 changes: 2 additions & 3 deletions lib/internal/policy/manifest.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,8 @@ class DependencyMapperInstance {
if (!target) {
throw new ERR_MANIFEST_INVALID_SPECIFIER(
this.href,
target +
', pattern needs to have a single' +
'trailing "*" in target');
`${target}, pattern needs to have a single trailing "*" in target`
);
}
const prefix = target[1];
const suffix = target[2];
Expand Down
9 changes: 9 additions & 0 deletions test/fixtures/policy-manifest/invalid.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"resources": {
"./fhqwhgads.js": {
"dependencies": {
"**": true
}
}
}
}
25 changes: 25 additions & 0 deletions test/parallel/test-policy-manifest.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
'use strict';

const common = require('../common');

if (!common.hasCrypto)
common.skip('missing crypto');

common.requireNoPackageJSONAbove();

const assert = require('assert');
const { spawnSync } = require('child_process');
const fixtures = require('../common/fixtures.js');

const policyFilepath = fixtures.path('policy-manifest', 'invalid.json');

const result = spawnSync(process.execPath, [
'--experimental-policy',
policyFilepath,
'./fhqwhgads.js',
]);

assert.notStrictEqual(result.status, 0);
const stderr = result.stderr.toString();
assert.match(stderr, /ERR_MANIFEST_INVALID_SPECIFIER/);
assert.match(stderr, /pattern needs to have a single trailing "\*"/);

0 comments on commit dab574e

Please sign in to comment.