Skip to content

Commit

Permalink
test: make sure test function resolves in test-worker-debug
Browse files Browse the repository at this point in the history
Use the common `.then(common.mustCall())` check to verify that.
Also, we should not use `process.abort()` in `test/parallel`; if
the test fails, that leaves core dumps lying around on POSIX systems.

PR-URL: #28155
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
addaleax authored and targos committed Jul 2, 2019
1 parent dec5b22 commit 993c0db
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/parallel/test-worker-debug.js
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ async function testWaitForDisconnectInWorker(session, post) {

session.disconnect();
console.log('Test done');
})().catch((err) => {
})().then(common.mustCall()).catch((err) => {
console.error(err);
process.abort();
process.exitCode = 1;
});

0 comments on commit 993c0db

Please sign in to comment.