Skip to content

Commit

Permalink
build: remove .git folders when testing V8
Browse files Browse the repository at this point in the history
When running `make test-v8` V8's `gclient sync` converts folders
under `deps/v8/third_party` into git repositories. Unfortunately
the files that were checked in under `deps/v8/third_party/zlib`
have been modified from the upstream Chromium repository (some
files have been deleted and there are whitespace differences in
some of the files that were kept) so whenever the Node.js source
tree is hard reset/checked out `gclient sync` notices there are
unstaged changes as the files in the Node.js source tree do not
match those of the upstream Chromium third party zlib commit.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #32877
Refs: nodejs/build#2256
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
richardlau authored and BridgeAR committed Apr 28, 2020
1 parent 4baf41f commit 832ea52
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tools/make-v8.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ BUILD_ARCH_TYPE=$1
V8_BUILD_OPTIONS=$2

cd deps/v8
find . -type d -name .git | xargs rm -rf
tools/node/fetch_deps.py .

ARCH="`arch`"
Expand Down

0 comments on commit 832ea52

Please sign in to comment.