http2: do not override the allowHalfOpen option

The constructors of `tls.Server` and `Http2Server` call the super constructors without options so the `allowHalfOpen` option is never used regardless of its value. PR-URL: #27623 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · May 13, 2019 · 74046ce · 74046ce
1 parent c33e834
commit 74046ce
Showing 1 changed file with 0 additions and 1 deletion.
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -2643,7 +2643,6 @@ function connectionListener(socket) {
 function initializeOptions(options) {
   assertIsObject(options, 'options');
   options = { ...options };
-  options.allowHalfOpen = true;
   assertIsObject(options.settings, 'options.settings');
   options.settings = { ...options.settings };