Skip to content

Commit

Permalink
lib: return directly if udp socket close before lookup
Browse files Browse the repository at this point in the history
PR-URL: #51914
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
theanarkh authored and richardlau committed Mar 25, 2024
1 parent 276d1d1 commit 3be5ff9
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lib/dgram.js
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,9 @@ Socket.prototype.bind = function(port_, address_ /* , callback */) {

// Resolve address first
state.handle.lookup(address, (err, ip) => {
if (!state.handle)
return; // Handle has been closed in the mean time

if (err) {
state.bindState = BIND_STATE_UNBOUND;
this.emit('error', err);
Expand Down Expand Up @@ -356,9 +359,6 @@ Socket.prototype.bind = function(port_, address_ /* , callback */) {
this.emit('error', ex);
});
} else {
if (!state.handle)
return; // Handle has been closed in the mean time

const err = state.handle.bind(ip, port || 0, flags);
if (err) {
const ex = new ExceptionWithHostPort(err, 'bind', ip, port);
Expand Down
19 changes: 19 additions & 0 deletions test/parallel/test-dgram-bind-socket-close-before-lookup.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
'use strict';
const common = require('../common');
const dgram = require('dgram');

// Do not emit error event in callback which is called by lookup when socket is closed
const socket = dgram.createSocket({
type: 'udp4',
lookup: (...args) => {
// Call lookup callback after 1s
setTimeout(() => {
args.at(-1)(new Error('an error'));
}, 1000);
}
});

socket.on('error', common.mustNotCall());
socket.bind(12345, 'localhost');
// Close the socket before calling DNS lookup callback
socket.close();

0 comments on commit 3be5ff9

Please sign in to comment.