Skip to content

Commit

Permalink
src: update NODE_MODULE_VERSION to 68
Browse files Browse the repository at this point in the history
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 7.1.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

PR-URL: #23423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
  • Loading branch information
targos committed Dec 6, 2018
1 parent 3c332ab commit 2360344
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/node_version.h
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,11 @@
* V8 6.8: 65
* V8 6.9: 66
* V8 7.0: 67
* V8 7.1: 68
*
* More information can be found at https://nodejs.org/en/download/releases/
*/
#define NODE_MODULE_VERSION 67
#define NODE_MODULE_VERSION 68

// the NAPI_VERSION provided by this version of the runtime
#define NAPI_VERSION 3
Expand Down

0 comments on commit 2360344

Please sign in to comment.