Skip to content

Commit

Permalink
test: move test-http-max-http-headers to parallel
Browse files Browse the repository at this point in the history
test-http-max-http-headers seems to run fine in parallel, even with
`tools/test.py -j 96 --repeat 192
test/parallel/test-http-max-http-headers.js`.

The same applies to `test-set-http-max-http-headers.js` which (as
written) depends on `test-http-max-http-headers.js` being in the same
directory. So that is being moved too.

PR-URL: #30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott authored and targos committed Dec 2, 2019
1 parent 1918b4e commit 1e199ce
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ test(function(cb) {
NODE_DEBUG: 'http'
});

// Validate that the test fails if the max header size is too small.
// Validate that the test now passes if the same limit becomes large enough.
// Validate that the test now passes if the same limit is large enough.
const args = ['--expose-internals',
'--max-http-header-size=1024',
testName,
Expand Down Expand Up @@ -76,8 +75,7 @@ if (!process.config.variables.node_without_node_options) {
});

test(function(cb) {
// Validate that the test now passes if the same limit
// becomes large enough.
// Validate that the test now passes if the same limit is large enough.
const args = ['--expose-internals', testName, '1024'];
const cp = spawn(process.execPath, args, { env, stdio: 'inherit' });

Expand Down

0 comments on commit 1e199ce

Please sign in to comment.