Skip to content

Commit

Permalink
benchmark: fix child-process-exec-stdout on win
Browse files Browse the repository at this point in the history
This benchmark fails on Windows when trying to execute command which
is more than 32k in size. This commits skips this one case when running
under Windows.

PR-URL: #7178
Reviewed-By: Trott - Rich Trott <rtrott@gmail.com>
Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>
  • Loading branch information
bzoz authored and Myles Borins committed Jul 14, 2016
1 parent 236491e commit 046d651
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion benchmark/child_process/child-process-exec-stdout.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
'use strict';
const common = require('../common.js');

var messagesLength = [64, 256, 1024, 4096];
// Windows does not support that long arguments
if (process.platform !== 'win32')
messagesLength.push(32768);
const bench = common.createBenchmark(main, {
len: [64, 256, 1024, 4096, 32768],
len: messagesLength,
dur: [5]
});

Expand Down

0 comments on commit 046d651

Please sign in to comment.