This repository has been archived by the owner on Jun 18, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Unexpectedly triggers report when new vm.Script
fails during compilation
#60
Comments
That's interesting, it might be because vm.Script runs in a kind of sandbox/context, with some special handling of exceptions. See https://nodejs.org/api/vm.html#vm_executing_javascript If I comment out node-report from the application, then run with --abort-on-uncaught-exception, I see the same effect:
So it looks like the V8 hook which both node-report and --abort-on-uncaught-exception use is being triggered. In the normal case there may be some extra long-stop that catches the SyntaxError and passes it back to the application. |
Also seeing this in the node repl, likely because that also uses vm.js:
|
I see this happening with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It appears that node-report is unexpectedly trigger uncaught exception reports when
vm.Script
fails during script compilation.In the example found below the caller clearly catches the exception. I would expect node-report not to automatically trigger a report in this situation.
Reproduction Example
Output Produced
The text was updated successfully, but these errors were encountered: