Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes can not be reliably detected #44

Closed
joyeecheung opened this issue Nov 2, 2017 · 1 comment
Closed

Some fixes can not be reliably detected #44

joyeecheung opened this issue Nov 2, 2017 · 1 comment

Comments

@joyeecheung
Copy link
Member

nodejs/node#16604

Body HTML is:

<p>Included reference to \'constant time\' in crypto.timingSafeEqual description</p>\n<p><span aria-label="This pull request closes issue #16504." class="issue-keyword tooltipped tooltipped-se">Fixes</span> : <a href="https://github.com/nodejs/node/issues/16504" class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="268571876" data-permission-text="Issue title is private" data-url="https://github.com/nodejs/node/issues/16504">#16504</a></p>

Where there is a space before :

@apapirovski
Copy link
Member

Also potentially relevant: https://help.github.com/articles/closing-issues-using-keywords/ — that's all the different versions that github supports, meaning a first-time contributor to Node might use one of the other formats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants