Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-cli causing CITGM to hard fail on Windows #802

Open
BethGriggs opened this issue Apr 15, 2020 · 4 comments
Open

ember-cli causing CITGM to hard fail on Windows #802

BethGriggs opened this issue Apr 15, 2020 · 4 comments

Comments

@BethGriggs
Copy link
Member

  • Node Version: Multiple
  • CitGM Version: Latest
  • Platform: Windows

It looks like ember-cli is causing CITGM to hard fail on Windows with the following error:

15:49:13 error: failure             | Test Timed Out      
15:49:17 [Error: EBUSY: resource busy or locked, rmdir 'C:\Users\ADMINI~1\AppData\Local\Temp\dbc0cb80-9c24-40ad-95d1-509c6b6462a7\ember-cli'] {
15:49:17   errno: -4082,
15:49:17   code: 'EBUSY',
15:49:17   syscall: 'rmdir',
15:49:17   path: 'C:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\dbc0cb80-9c24-40ad-95d1-509c6b6462a7\\ember-cli'
15:49:17 }

https://ci.nodejs.org/job/citgm-smoker/nodes=win-vs2017/2348/console

I've seen this on v13.x and v14.x. The hard fail means that Windows results do not appear in the aggregated results view, so we're potentially missing some failures.

@richardlau
Copy link
Member

I think this is related to #779 and is related to tests timing out. We don't kill any child processes spawned by tests when tests time out which may prevent the temp directory CITGM creates to test the module from being removed. I'm not sure if there's a cross-platform way of killing all spawned processes.

We could possibly ignore (but still warn) when we fail to remove the temp directory we create at the end of test run for a module.

@richardlau
Copy link
Member

I've not been able to find a cross-platform module to kill a process tree of spawned processes (at best there are modules that support Linux, macOS and Windows but not, for example, AIX).

Raised #829 to handle the errors and continue.

@huseyinacacak-janea
Copy link

Hi @BethGriggs, do you think this is already fixed by now and can be closed?

@BethGriggs
Copy link
Member Author

I've started a pipeline run on ember-cli to see - https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/251/console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants