-
Notifications
You must be signed in to change notification settings - Fork 165
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node installer built in Electron #440
Comments
what about the file size? will it go up? i mean, this is electron we're talking about here |
@ore Probably but it could act like a sort of version installer. Could have an option of which version from in it. Also it doesn't make the binaries go up in size at all, probably. Do consider how many problems we've had which the current installer programs... they are just a mess all around, especially for OS X. |
@Fishrock123 yeah, that was my only concern pretty much. a multi-version installer sounds nice and reduces efforts on the website! |
This is the application size for various deploy targets taken from electron/electron#2003 (comment) I do think @Fishrock123's point is a good one though... this could be a one time installer and updater as opposed to what we have now |
just imagine! we'll be the first project of this size to only have one download button on our website! |
We could also end the install with onboarding into documentation on how to use Node.js. Also, we could include a version switcher, that would make things really nice. |
in theory the docs could be embedded in the application |
The biggest issue I've seen with OS X installers seems to be dependent on whether node/npm are owned by root. Can you get administrator access via electron on OS X? |
Looks like there is a discussion about this alread /cc @maxogden |
I'm not 100% this is what we want, but --> https://github.com/electron-userland/electron-builder Seems to be capable of making a |
I'd be in support for @mikeal's point of the version manager. |
From nodejs/node#7371: should include clean uninstallers. |
it is happening https://github.com/nodejs/installer |
So there have been many threads about the variety of ways in which our installer is less than perfect. Dealing with installer frameworks is kind of the worst.
Would anyone be interested in exploring an alternative installer built with electron?
The text was updated successfully, but these errors were encountered: