Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Cloudflare configuration update #3473

Closed
ovflowd opened this issue Aug 24, 2023 · 12 comments
Closed

Request: Cloudflare configuration update #3473

ovflowd opened this issue Aug 24, 2023 · 12 comments

Comments

@ovflowd
Copy link
Member

ovflowd commented Aug 24, 2023

Hey 👋 as seen in some discussions on Slack, we've noticed a few little changes we can accomplish to improve (assumingly) the situation related to Node.js Website 5XX Errors when serving binaries.

The changes are outlined in the images below, and the red markers demonstrate what fields need to be changed. (The values shown within these images are the desired result).

Slack Threads:

Cache Rules Updates

image

image

image

image

Origin Rules Updates

The changes below are unrelated but meant to fix some broken links since we've moved to Vercel. The image below shows the entries that should be removed from the Vercel Origin Rule.

image

The images below are new Redirect Rules that should be created:

image

image

image

@Trott
Copy link
Member

Trott commented Aug 24, 2023

@nodejs/build

@Trott
Copy link
Member

Trott commented Aug 24, 2023

(Added the build-agenda label so it gets discussed at a meeting in case this stalls or otherwise doesn't get done. Feel free to remove if that's not appropriate. I'm just trying to help Claudio with visibility on this issue.)

@Trott
Copy link
Member

Trott commented Sep 21, 2023

If someone has the appropriate access to do this but doesn't want to make more than a small change at a time to caching, perhaps the "don't cache status codes 500 and above" part can be a smaller change that would hopefully have some positive effect?

image

@ovflowd
Copy link
Member Author

ovflowd commented Sep 21, 2023

If someone has the appropriate access to do this but doesn't want to make more than a small change at a time to caching, perhaps the "don't cache status codes 500 and above" part can be a smaller change that would hopefully have some positive effect?

image

There's a small typo on the image, on the image both are "No cache" but it should be "No cache" and then "No store"

@mhdawson
Copy link
Member

mhdawson commented Sep 25, 2023

@ovflowd I tried doing the small change today, but unfortunately Cloudflare tells me status_code ranges should not overlap (Code: 20110) so the fix for the typo does not seem to be correct.

@mhdawson
Copy link
Member

I set it to be one entry which is just the No store as from some reading I believe that was what was needed.

@ovflowd
Copy link
Member Author

ovflowd commented Sep 25, 2023

I guess tat's fine! (cc @MattIPv4) (Is no store preferrable to no cache?)

@MattIPv4
Copy link
Member

👍 No store makes sense here, it is a more aggressive no cache aiui.

@ovflowd
Copy link
Member Author

ovflowd commented Sep 26, 2023

@targos would you have time for making the other changes? (Except the one that @mhdawson already did?)

@MoLow
Copy link
Member

MoLow commented Sep 26, 2023

I'l take a look at the other changes. CC @nodejs/build

@MoLow
Copy link
Member

MoLow commented Sep 26, 2023

  1. changed bypass cache for vercel-paths from (http.host eq "nodejs.org" and not http.request.uri.path matches "^/(dist|download|docs|api|documentation|metrics)") to (http.host eq "nodejs.org" and not http.request.uri.path matches "^/(dist|download|docs|api|metrics)")
  2. changed cache non-vercel paths from (http.host eq "nodejs.org" and http.request.uri.path matches "^/(dist|download|docs|api|documentation|metrics)") or (http.host eq "origin.nodejs.org") to (http.host eq "nodejs.org" and http.request.uri.path matches "^/(dist|download|docs|api|metrics)") or (http.host eq "origin.nodejs.org")
  3. adding no store for > 500 status code has already been taken care of by @mhdawson
  4. removed benchmarking.nodejs.org, foundation.nodejs.org and interactive.nodejs.org from redirecting to origin.nodejs.org
  5. added new redirect rules benchmarking.nodejs.org, foundation.nodejs.org and interactive.nodejs.org from redirecting to nodejs.org

thanks @ovflowd

@MoLow MoLow closed this as completed Sep 26, 2023
@ovflowd
Copy link
Member Author

ovflowd commented Sep 26, 2023

Thank you so much, @MoLow !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants