Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to check for memory leaks in addon/default leak. #440

Closed
mhdawson opened this issue Sep 9, 2022 · 4 comments
Closed

Document how to check for memory leaks in addon/default leak. #440

mhdawson opened this issue Sep 9, 2022 · 4 comments
Milestone
Milestone 11

Comments

@mhdawson
Copy link
Member

mhdawson commented Sep 9, 2022

Add to Node.js api docs

  1. info on checking addons for memory leaks
  2. that by default you will see one leak as outlined in - napi mem leak test on valgrind node#44518
@mhdawson mhdawson added this to the Milestone 11 milestone Sep 9, 2022
@mhdawson
Copy link
Member Author

mhdawson commented Feb 3, 2023

@KevinEady is going to take a look at this one.

Suggestion is to add to doc in node-addon-api repo

@KevinEady
Copy link
Contributor

I've been working on this, but what I have runs more like a blog-post than a documentation guide. PTAL and add comments as necessary: Checking Node Add-ons for Memory Leaks using Valgrind.

Would this be okay as a format for the node-addon-api doc?

@legendecas legendecas mentioned this issue Apr 18, 2023
Closed
@KevinEady
Copy link
Contributor

PR created nodejs/node#47760

@mhdawson
Copy link
Member Author

mhdawson commented May 5, 2023

PR landed, done

@mhdawson mhdawson closed this as completed May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Milestone 11
Development

No branches or pull requests
2 participants
@KevinEady @mhdawson