Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests in solid-contrib/solid-crud-tests #1736

Open
mrvahedi68 opened this issue Aug 22, 2023 · 4 comments
Open

Failing tests in solid-contrib/solid-crud-tests #1736

mrvahedi68 opened this issue Aug 22, 2023 · 4 comments

Comments

@mrvahedi68
Copy link

During the testing process on https://solid-crud-tests-example-1.solidcommunity.net, several tests have unfortunately not yielded successful results.

The tests in question specifically pertain to the Notification and Storage categories. To provide a concise overview:

FAIL  test/surface/notifications.test.ts
Notifications
When overwriting plain text with plain text using PUT
  ✕ WPS  insecure websockets-pubsub advertised using Updates-Via Link header (11 ms)
  ✓ WPS  emits insecure websockets-pubsub on the resource (1 ms)
  ✕ SECURE_WEBSOCKETS  secure websockets advertised using server-wide or resource-specific Link header (3 ms)
  ✓ SECURE_WEBSOCKETS  emits secure websockets notification on the resource
  ✕ WEBHOOKS  webhooks advertised using server-wide or resource-specific Link header (1 ms)
  ✕ WEBHOOKS  emits webhook notification on the resource (1 ms)
 

FAIL  test/surface/fetch-pod-root.test.ts
Alice's storage root
  ✕ is an ldp BasicContainer (3 ms)
@michielbdejong
Copy link
Member

@mrvahedi68
Copy link
Author

By setting ALICE_WEBID=https://solid-crud-tests-example-1.solidcommunity.net/profile/card#me One of them passed:

PASS  test/surface/fetch-pod-root.test.ts
Alice's storage root
 ✓ is an ldp BasicContainer (1222 ms)

@mrvahedi68
Copy link
Author

Ah god, Problem was with the main branch !!!
I must use nss-skips branch and here is the results:

Screen Shot 1402-06-02 at 23 32 34

The requested changes in this PR is required for this branch also.

@michielbdejong
Copy link
Member

OK, solid-contrib/solid-crud-tests#67 merged - can you create the equivalent PR against the nss-skips branch? And then I think we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants