-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support HTTP2 #516
feat: support HTTP2 #516
Conversation
closes #474
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #516 +/- ##
==========================================
+ Coverage 97.03% 98.83% +1.79%
==========================================
Files 10 10
Lines 1618 1628 +10
Branches 267 275 +8
==========================================
+ Hits 1570 1609 +39
+ Misses 44 19 -25
+ Partials 4 0 -4 ☔ View full report in Codecov by Sentry. |
@coderabbitai 提交一个 issue,跟进这个 pr 的功能合并到 master 分支 |
Tip For best results, initiate chat on the files or code changes. @fengmk2, I have successfully created an issue to track the merging of the HTTP2 support features from the PR into the master branch. You can follow the progress and discussions here. Analysis chainScripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Creating a GitHub issue to track the merging of HTTP2 support features from PR to master branch.
gh issue create --title "Track HTTP2 support feature merge into master" --body "This issue is to track the progress and discussions related to merging the HTTP2 support features implemented in PR https://github.com/node-modules/urllib/pull/516 into the master branch." --assignee fengmk2
Length of output: 339 |
[skip ci] ## [3.26.0](v3.25.1...v3.26.0) (2024-06-26) ### Features * support HTTP2 ([#516](#516)) ([d1e4add](d1e4add))
closes #474 pick from #516 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced HTTP/2 support in `HttpClient` with the new `allowH2` option. - Added `getGlobalDispatcher` function for managing global dispatchers. - **Documentation** - Updated README with a new section on making requests using HTTP/2 in `HttpClient`. - **Tests** - Added test cases for the `allowH2` option in `HttpClient`. - **Chores** - Updated Node.js versions in GitHub Actions configuration to include additional versions and correct an existing version. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
base on node-modules/urllib#516 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced the ability to enable HTTP/2 support through the `allowH2` property when using the next-generation HTTP client. - **Bug Fixes** - Enhanced clarity and accuracy of comments for HTTP client configuration properties. - **Improvements** - Updated `urllib-next` dependency to version `^3.26.0` for better performance and stability. - Added tests to verify HTTP/2 functionality and custom HTTP client behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
closes #474