Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support HTTP2 #516

Merged
merged 6 commits into from
Jun 26, 2024
Merged

feat: support HTTP2 #516

merged 6 commits into from
Jun 26, 2024

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jun 26, 2024

closes #474

@fengmk2 fengmk2 added the enhancement New feature or request label Jun 26, 2024
@fengmk2 fengmk2 self-assigned this Jun 26, 2024
@fengmk2 fengmk2 marked this pull request as draft June 26, 2024 05:51
Copy link

coderabbitai bot commented Jun 26, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.83%. Comparing base (b414140) to head (3187055).

Additional details and impacted files
@@            Coverage Diff             @@
##              3.x     #516      +/-   ##
==========================================
+ Coverage   97.03%   98.83%   +1.79%     
==========================================
  Files          10       10              
  Lines        1618     1628      +10     
  Branches      267      275       +8     
==========================================
+ Hits         1570     1609      +39     
+ Misses         44       19      -25     
+ Partials        4        0       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengmk2 fengmk2 marked this pull request as ready for review June 26, 2024 16:23
@fengmk2 fengmk2 changed the title feat: support HTTP2.0 feat: support HTTP2 Jun 26, 2024
@fengmk2
Copy link
Member Author

fengmk2 commented Jun 26, 2024

@coderabbitai 提交一个 issue,跟进这个 pr 的功能合并到 master 分支

Copy link

coderabbitai bot commented Jun 26, 2024

Tip

For best results, initiate chat on the files or code changes.

@fengmk2, I have successfully created an issue to track the merging of the HTTP2 support features from the PR into the master branch. You can follow the progress and discussions here.

Analysis chain
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Creating a GitHub issue to track the merging of HTTP2 support features from PR to master branch.
gh issue create --title "Track HTTP2 support feature merge into master" --body "This issue is to track the progress and discussions related to merging the HTTP2 support features implemented in PR https://github.com/node-modules/urllib/pull/516 into the master branch." --assignee fengmk2

Length of output: 339

@fengmk2 fengmk2 merged commit d1e4add into 3.x Jun 26, 2024
23 checks passed
@fengmk2 fengmk2 deleted the allow-h2 branch June 26, 2024 16:50
fengmk2 pushed a commit that referenced this pull request Jun 26, 2024
[skip ci]

## [3.26.0](v3.25.1...v3.26.0) (2024-06-26)

### Features

* support HTTP2 ([#516](#516)) ([d1e4add](d1e4add))
fengmk2 added a commit that referenced this pull request Jun 26, 2024
closes #474

pick from #516
@fengmk2 fengmk2 mentioned this pull request Jun 26, 2024
fengmk2 added a commit to eggjs/egg that referenced this pull request Jun 27, 2024
fengmk2 added a commit that referenced this pull request Jun 27, 2024
closes #474

pick from #516

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced HTTP/2 support in `HttpClient` with the new `allowH2`
option.
- Added `getGlobalDispatcher` function for managing global dispatchers.

- **Documentation**
- Updated README with a new section on making requests using HTTP/2 in
`HttpClient`.

- **Tests**
  - Added test cases for the `allowH2` option in `HttpClient`.

- **Chores**
- Updated Node.js versions in GitHub Actions configuration to include
additional versions and correct an existing version.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
fengmk2 added a commit to eggjs/egg that referenced this pull request Jun 27, 2024
base on node-modules/urllib#516


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced the ability to enable HTTP/2 support through the `allowH2`
property when using the next-generation HTTP client.
  
- **Bug Fixes**
- Enhanced clarity and accuracy of comments for HTTP client
configuration properties.

- **Improvements**
- Updated `urllib-next` dependency to version `^3.26.0` for better
performance and stability.
- Added tests to verify HTTP/2 functionality and custom HTTP client
behavior.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant