Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update convert_bin #84

Merged
merged 1 commit into from
Aug 14, 2020
Merged

update convert_bin #84

merged 1 commit into from
Aug 14, 2020

Conversation

tttak
Copy link

@tttak tttak commented Aug 14, 2020

I modified convert_bin about checking fen invalidity.

  • Add option to check fen invalidity or not. check_invalid_fen 1 or 0.
  • Only compare "Piece placement field" between input_fen and pos.fen().
learn convert_bin in.txt output_file_name out.bin check_invalid_fen 1 check_illegal_move 1
convert in.txt ... done 16 parsed 3 is filtered (invalid fen:1, illegal move:2, invalid ply:0)

learn convert_bin in.txt output_file_name out.bin check_invalid_fen 1 check_illegal_move 1
convert in.txt ... done 16 parsed 3 is filtered (invalid fen:1, illegal move:2, invalid ply:0)
@nodchip nodchip merged commit 69a95e4 into nodchip:master Aug 14, 2020
@nodchip
Copy link
Owner

nodchip commented Aug 14, 2020

Thank you for the pull request. I merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants