Small changes to OMPS nadir mapper level 2 reader #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmoon
reviewed
Oct 4, 2024
Co-authored-by: Zachary Moon <zmoon92@gmail.com>
zmoon
reviewed
Oct 4, 2024
Condense exceptions and associated error statements, improved information in error statement Co-authored-by: Zachary Moon <zmoon92@gmail.com>
Co-authored-by: Zachary Moon <zmoon92@gmail.com>
zmoon
reviewed
Oct 7, 2024
Co-authored-by: Zachary Moon <zmoon92@gmail.com>
|
@mbruckner-work I can go ahead and resolve the linter/formatter stuff if you want. |
|
@zmoon That would be great. Thanks! |
zmoon
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
@mbruckner-work If you're satisfied, I will merge this. It's just the ISH tests failing afaict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing the fix to the Melodies Monet driver I came across a small change I made to the OMPS reader that allows for using a list of files instead of expanding a string with glob to get the satellite files to read in. This change is necessary for processing over time intervals in Melodies Monet.