Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AERONET dates when parallel option used #125

Merged
merged 8 commits into from
Sep 25, 2023
Merged

AERONET dates when parallel option used #125

merged 8 commits into from
Sep 25, 2023

Conversation

zmoon
Copy link
Member

@zmoon zmoon commented Jul 11, 2023

Resolves #100

@zmoon
Add failing test
fa4b376
@zmoon
Sort of fix
307799b 
But will fail if day or less requested
@zmoon
WIP
44b6fca 
In the two day case, the parallel run has somewhat fewer rows

Removing the `.drop_duplicates()` didn't change things

Will have to investigate more
@zmoon
Multi-day test now passes
90c5b5d 
just have to sort first before comparing
@zmoon
notes [skip ci]
f7321b3
@zmoon zmoon mentioned this pull request Sep 20, 2023
Closed
zmoon
zmoon commented Sep 20, 2023
View reviewed changes
monetio/obs/aeronet.py Outdated Show resolved Hide resolved
@zmoon zmoon marked this pull request as ready for review September 20, 2023 23:42
@zmoon zmoon merged commit ce5d939 into noaa-oar-arl:develop Sep 25, 2023
8 checks passed
@zmoon zmoon deleted the aeronet-parallel-dates branch September 25, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbakernoaa bbakernoaa bbakernoaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmoon @bbakernoaa