Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ unittest/modelfile ] Fix backbone_n_15 @open sesame 10/17 17:36 #2769

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

skykongkong8
Copy link
Member

  • The original purpose of this TC is to make sure the model is not compiled when input layer is not clarified.
  • As far as I am concerned, without any information about input layer, the model should fail to compile, and since it is not compiled, should not support initialization.
  • Related commit hashes:
    original purpose : 68e7dab
    wrong fix : e1c5915

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 24, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2769. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Collaborator

@jijoongmoon jijoongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jijoongmoon jijoongmoon changed the title [ Wait for #2768 ] [ unittest/modelfile ] Fix backbone_n_15 [ Wait for #2768 ] [ unittest/modelfile ] Fix backbone_n_15 @open sesame 10/17 17:36 Oct 24, 2024
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.

- The original purpose of this TC is to make sure the model is not compiled when input layer is not clarified.
- Without any information about input layer, it should be failed to compile, and since it is not compiled, should not support initialization.
- Related commit hashes:
original purpose : 68e7dab
wrong fix : e1c5915

**Self evaluation:**
1. Build test:     [X]Passed [ ]Failed [ ]Skipped
2. Run test:     [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: skykongkong8 <ss.kong@samsung.com>
@skykongkong8 skykongkong8 changed the title [ Wait for #2768 ] [ unittest/modelfile ] Fix backbone_n_15 @open sesame 10/17 17:36 [ unittest/modelfile ] Fix backbone_n_15 @open sesame 10/17 17:36 Oct 25, 2024
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@lhs8928 lhs8928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jijoongmoon jijoongmoon merged commit f90e87e into nnstreamer:main Oct 25, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants