-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ unittest ] Remove improperly formulated TCs @open sesame 10/23 13:26 #2765
Conversation
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2765. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
e14f378
to
f5abcff
Compare
f5abcff
to
4aeb02c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.
f5abcff
to
e14f378
Compare
- unittest_nntrainer_modelfile have not been initialized properly, and fixing this issue shown multiple failing TCS. - Temporally remove TCs, and upcoming commit will introduce them **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: skykongkong8 <ss.kong@samsung.com>
e14f378
to
2796ea2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An error is currently occurring in CI.
When checking the log in git actions, there is "error: redefinition of 'class nntrainer_Tensor_copy_and_shares_variable_03_p_Test'".
Previously, a unit test with the same name was added to @EunjuYang's commit 85d7a54 and @djeong20's commit 49b9eb6.
Currently, there are two instances of copy_and_shares_variable_03_p.
It seems that changing the name of the unit test would solve this issue.
- current upstream includes duplicated TC : copy_and_shares_variable_03_p - remove duplicated TC name from unittest_nntrainer_tensor.cpp **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: skykongkong8 <ss.kong@samsung.com>
Got it! Thanks :) To reviewers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.
Self evaluation: