Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ unittest ] Remove improperly formulated TCs @open sesame 10/23 13:26 #2765

Merged
merged 2 commits into from
Oct 24, 2024
Merged

[ unittest ] Remove improperly formulated TCs @open sesame 10/23 13:26 #2765

merged 2 commits into from
Oct 24, 2024

Conversation

skykongkong8
Copy link
Member

@skykongkong8 skykongkong8 commented Oct 22, 2024 •
edited
Loading

  • unittest_nntrainer_modelfile have not been even "initialized" properly, and fixing this issue shown multiple failing TCs.
  • Temporally remove TCs, and upcoming commit will fix them again.
  • Still, this commit makes 127 TCs to run additionally.
  • Added todo comments for each commented-out TCs.

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 22, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2765. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

taos-ci
taos-ci approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.

DonghakPark
DonghakPark approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skykongkong8 skykongkong8 changed the title [ unittest ] Remove unproperly formulated TCs [ unittest ] Remove improperly formulated TCs Oct 22, 2024
@skykongkong8 skykongkong8 changed the title [ unittest ] Remove improperly formulated TCs [ unittest ] Remove improperly formulated TCs @open sesame 10/23 13:26 Oct 23, 2024
taos-ci
taos-ci approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.

@skykongkong8 skykongkong8 force-pushed the tmp/TestHub/layers branch 2 times, most recently from f5abcff to e14f378 Compare October 23, 2024 06:29
@skykongkong8
[ unittest ] Remove unproperly formulated TCs
2796ea2 
- unittest_nntrainer_modelfile have not been initialized properly, and fixing this issue shown multiple failing TCS.
- Temporally remove TCs, and upcoming commit will introduce them

**Self evaluation:**
1. Build test:     [X]Passed [ ]Failed [ ]Skipped
2. Run test:     [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: skykongkong8 <ss.kong@samsung.com>
SeoHyungjun
SeoHyungjun reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@SeoHyungjun SeoHyungjun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error is currently occurring in CI.

When checking the log in git actions, there is "error: redefinition of 'class nntrainer_Tensor_copy_and_shares_variable_03_p_Test'".

Previously, a unit test with the same name was added to @EunjuYang's commit 85d7a54 and @djeong20's commit 49b9eb6.

Currently, there are two instances of copy_and_shares_variable_03_p.

It seems that changing the name of the unit test would solve this issue.

@skykongkong8
[ unittest ] Duplicated TC name
77fcddc 
- current upstream includes duplicated TC : copy_and_shares_variable_03_p
- remove duplicated TC name from unittest_nntrainer_tensor.cpp

**Self evaluation:**
1. Build test:     [X]Passed [ ]Failed [ ]Skipped
2. Run test:     [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: skykongkong8 <ss.kong@samsung.com>
@skykongkong8
Copy link
Member Author

skykongkong8 commented Oct 23, 2024 •
edited
Loading

An error is currently occurring in CI.

When checking the log in git actions, there is "error: redefinition of 'class nntrainer_Tensor_copy_and_shares_variable_03_p_Test'".

Previously, a unit test with the same name was added to @EunjuYang's commit 85d7a54 and @djeong20's commit 49b9eb6.

Currently, there are two instances of copy_and_shares_variable_03_p.

It seems that changing the name of the unit test would solve this issue.

Got it! Thanks :)

To reviewers:
In short, latest (Commits on Oct 23, 2024) upstream main includes duplicated TCs. This PR resolves it.

taos-ci
taos-ci approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.

@jijoongmoon jijoongmoon merged commit 363a419 into nnstreamer:main Oct 24, 2024
38 checks passed
@skykongkong8 skykongkong8 deleted the tmp/TestHub/layers branch October 24, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeoHyungjun SeoHyungjun SeoHyungjun left review comments

@EunjuYang EunjuYang EunjuYang approved these changes

@taos-ci taos-ci taos-ci approved these changes

@DonghakPark DonghakPark DonghakPark approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@kparichay kparichay Awaiting requested review from kparichay

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

@lhs8928 lhs8928 Awaiting requested review from lhs8928 lhs8928 is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@baek2sm baek2sm Awaiting requested review from baek2sm baek2sm is a code owner

@djeong20 djeong20 Awaiting requested review from djeong20 djeong20 is a code owner

Assignees
No one assigned
Labels
PR/READY2MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@skykongkong8 @taos-ci @EunjuYang @SeoHyungjun @DonghakPark @jijoongmoon