Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unittest] Add network_graph & lr_cosine unit test case #2762

Merged
merged 2 commits into from
Oct 22, 2024
Merged

[Unittest] Add network_graph & lr_cosine unit test case #2762

merged 2 commits into from
Oct 22, 2024

Conversation

DonghakPark
Copy link
Member

@DonghakPark DonghakPark commented Oct 21, 2024 •
edited
Loading

  1. [Unittest] Add network_graph unit test
  • add reinitialize / catch exceptions
  • These tests are not limited to specific layers but rather serve as test cases for checking activities performed on actual network graphs.
  1. [Unittest] Add lr_scheduler_cosine unit test
  • property setting test / finalize test / getLearningRate test
  • add to api and make helper function

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

@DonghakPark
[Unittest] Add network_graph unit test
72ecd76 
Add More unit test on network_graph
- add reinitialize
- catch exceptions

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <donghak.park@samsung.com>
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 21, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2762. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@DonghakPark DonghakPark self-assigned this Oct 21, 2024
taos-ci
taos-ci approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonghakPark, 💯 All CI checkers are successfully verified. Thanks.

@DonghakPark
Copy link
Member Author

After adding more diverse test cases for functions and classes, I will remove the "Do Not Merge" label and Request review.

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 21, 2024

:octocat: cibot: @DonghakPark, api/ccapi/include/optimizer.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

@DonghakPark
[Unittest] Add lr_scheduler_cosine unit test
5423dab 
Add lr_scheduler_cosine Unit test case
- property setting test
- finalize test
- getLearningRate test

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <donghak.park@samsung.com>
@nnstreamer nnstreamer deleted a comment from taos-ci Oct 21, 2024
@DonghakPark DonghakPark changed the title [Unittest] Add network_graph unit test [Unittest] Add network_graph & lr_cosine unit test case Oct 21, 2024
taos-ci
taos-ci approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonghakPark, 💯 All CI checkers are successfully verified. Thanks.

baek2sm
baek2sm approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@baek2sm baek2sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!
I like it because there are many negative test cases :)

skykongkong8
skykongkong8 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@skykongkong8 skykongkong8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jijoongmoon jijoongmoon merged commit 5eb2d6b into nnstreamer:main Oct 22, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baek2sm baek2sm baek2sm approved these changes

@taos-ci taos-ci taos-ci approved these changes

@skykongkong8 skykongkong8 skykongkong8 approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@kparichay kparichay Awaiting requested review from kparichay

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

@lhs8928 lhs8928 Awaiting requested review from lhs8928 lhs8928 is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@SeoHyungjun SeoHyungjun Awaiting requested review from SeoHyungjun SeoHyungjun is a code owner

@djeong20 djeong20 Awaiting requested review from djeong20 djeong20 is a code owner

@EunjuYang EunjuYang Awaiting requested review from EunjuYang EunjuYang is a code owner

Assignees

@DonghakPark DonghakPark

Labels
PR/READY2MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DonghakPark @taos-ci @baek2sm @skykongkong8 @jijoongmoon