[Tensor] ShortTensor class with unsigned 16-bit integer #2697
Conversation
djeong20
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
helloahn,
kparichay,
gichan-jang,
anyj0527,
zhoonit,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8,
EunjuYang and
a team
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2697. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
|
|
cibot:
djeong20
force-pushed
the
add/short_tensor
branch
from
3fa6c3a
to
ddce9b3
Compare
In this PR, a new type of tensor, the ShortTensor class, is designed explicitly for handling unsigned 16-bit integer data types. This new tensor class aims to provide users with more options when working with various data types. Note that the ShortTensor class does not support mathematical operations like multiplication or addition. **Self-evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghyeon Jeong <dhyeon.jeong@samsung.com>
djeong20
force-pushed
the
add/short_tensor
branch
from
ddce9b3
to
eb0281c
Compare
djeong20
changed the title
|
|
||
| /** | ||
| * @brief Construct a new ShortTensor object | ||
| * |
| // SPDX-License-Identifier: Apache-2.0 | ||
| /** | ||
| * @file short_tensor.cpp | ||
| * @date 02 April 2024 |
|
|
||
| void ShortTensor::setValue(float value) { | ||
| uint16_t *data = (uint16_t *)getData(); | ||
| std::fill(data, data + size(), value); |
There was a problem hiding this comment.
Is it ok to use float data type without casting?
There was a problem hiding this comment.
Nice catch!
I also think it needs fixing
In this PR, a new type of tensor, the ShortTensor class, is designed explicitly for handling unsigned 16-bit integer data types.
This new tensor class aims to provide users with more options when working with various data types.
Note that the ShortTensor class does not support mathematical operations like multiplication or addition.
Self-evaluation:
Signed-off-by: Donghyeon Jeong dhyeon.jeong@samsung.com