Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix division-by-zero while initializing CMAES #86

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

engintoklu
Copy link
Collaborator

While computing its default C decomposition frequency, under some conditions (e.g. with a problem of solution length 1000), initialization of CMAES failed due to division-by-zero (which later resulted in a failing attempt to convert inf to an integer). This pull request aims to fix this issue.

While computing its default C decomposition
frequency, under some conditions (e.g. with a
problem of solution length 1000), initialization
of CMAES failed due to division-by-zero.
This commit aims to fix this issue.
@engintoklu engintoklu added the bug Something isn't working label Aug 3, 2023
@engintoklu engintoklu mentioned this pull request Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #86 (6130253) into master (9d31d59) will decrease coverage by 0.03%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   77.83%   77.81%   -0.03%     
==========================================
  Files          49       49              
  Lines        7332     7338       +6     
==========================================
+ Hits         5707     5710       +3     
- Misses       1625     1628       +3     
Files Changed Coverage Δ
src/evotorch/algorithms/cmaes.py 82.95% <87.50%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

@engintoklu engintoklu self-assigned this Aug 4, 2023
Copy link
Collaborator

@NaturalGradient NaturalGradient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a niche big :)

@Higgcz Higgcz merged commit e796e01 into master Oct 2, 2023
3 checks passed
@Higgcz Higgcz deleted the fix/cmaes-c-decompose branch October 2, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants