fix: get_minibatch() of SupervisedNE #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes/improves SupervisedNE in two ways: 1) The `get_minibatch()` method of `SupervisedNE` no longer uses recursion to handle the end of the data loader's minibatches. The new implementation catches only `StopIteration` and non-recursively restarts the iterator of the data loader. Any other type of error is now deliberately unhandled to avoid unwanted infinite recursion and to allow the user to see the details of the error. 2) The example notebook `Training_MNIST30K.ipynb` demonstrating the usage of `SupervisedNE` is updated so that its hyperparameter configuration follows what is reported in the technical report of EvoTorch. This way, results reported in the report can be reproduced. Co-authored-by: Timothy Atkinson <timothy@nnaisense.com> Co-authored-by: Nihat Engin Toklu <engin@nnaisense.com>
engintoklu
requested review from
Higgcz,
flukeskywalker,
NaturalGradient and
pliskowski
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
- Coverage 77.85% 77.83% -0.03%
==========================================
Files 49 49
Lines 7330 7332 +2
==========================================
Hits 5707 5707
- Misses 1623 1625 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes/improves
SupervisedNEin two ways:1)
The
get_minibatch()method ofSupervisedNEno longer uses recursion to handle the end of the data loader's minibatches. The new implementation catches onlyStopIterationand non-recursively restarts the iterator of the data loader. Any other type of error is now deliberately unhandled to avoid unwanted infinite recursion and to allow the user to see the details of the error.2)
The example notebook
Training_MNIST30K.ipynbdemonstrating the usage ofSupervisedNEis updated so that its hyperparameter configuration follows what is reported in the technical report of EvoTorch. This way, results reported in the report can be reproduced.