Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.HTMLConverter: convert also placeholder and aria-label attributes. #19

Open
firmart opened this issue Dec 22, 2021 · 2 comments
Open

.HTMLConverter: convert also placeholder and aria-label attributes. #19

firmart opened this issue Dec 22, 2021 · 2 comments

Comments

@firmart
Copy link

firmart commented Dec 22, 2021

The .HTMLConverter API works perfectly for text nodes, but it would be even nicer if it could also convert attributes like placeholder, aria-label etc.

Thanks.
@sgalal
Copy link
Contributor

sgalal commented Dec 22, 2021

Thanks! Could you make a pull request?

@firmart
Copy link
Author

firmart commented Dec 22, 2021

I just had a look at the source code, it does seem fairly easy to achieve. Will look if I got time before next year... Thanks for the quick reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@firmart @sgalal