lib/types: merge into extendedLib

[MattSturgeon]

• lib/types: merge into extendedLib
• lib: migrate helpers.nixvimTypes -> lib.types

As discussed in #1975 (comment)

I think this is the cleanest way for us to have custom option types, however we do loose some clarity. You can no longer tell at a glance whether a type is from nixvim or nixpkgs.

@GaetanLepage seems on board, what's your view @traxys?

[GaetanLepage]

Let's wait for @traxys' ACK for this one.

[MattSturgeon]

@traxys @khaneliman It'd be great to have your opinions on this PR. #1982 is currently blocked waiting for a decision here.

As laid out in the description, I'm undecided whether or not this is a good idea.

There's value in keeping our changes to lib scoped within the lib.nixvim namespace, so I'm not married to this idea.

But based on our internal usage, we tend to use lib.types and lib.nixvim.nixvimTypes interchangeably anyway...

[khaneliman]

IMO it's a good quality of life change. As mentioned, we already do a lot of types = nixvimtypes and this would make it less cumbersome to utilize our library types; I know some don't like this much 'magic', though.

[traxys]

I don't have much of an opinion on this

[MattSturgeon]

Ok, since we have no descent I'll rebase and merge.

To summarise:

• @traxys neutral
• @MattSturgeon neutral, but slightly in favour
• @khaneliman in favour
• @GaetanLepage in favour

Thanks all for sharing your views!

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at b7f419a