Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly support nested identifiers #27

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

infinisil
Copy link
Collaborator

Makes definitions like

/* Some comment */
foo.bar.baz = 10;

correctly identify "foo.bar.baz" as the item name, instead of just "foo"

infinisil added a commit to NixOS/nixpkgs that referenced this pull request Dec 9, 2022
Applies nix-community/nixdoc#27 and fixes up the
location information rendering, allowing lib functions to be nested in
further scopes
@fricklerhandwerk
Copy link
Contributor

@mightyiam maybe you're interested to take a look?

infinisil added a commit to NixOS/nixpkgs that referenced this pull request Dec 23, 2022
Applies nix-community/nixdoc#27 and fixes up the
location information rendering, allowing lib functions to be nested in
further scopes

Needed for later commits
Copy link
Contributor

@asymmetric asymmetric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clippy nit, otherwise LGTM.

src/main.rs Outdated Show resolved Hide resolved
Makes definitions like

    /* Some comment */
    foo.bar.baz = 10;

correctly identify "foo.bar.baz" as the item name, instead of just "foo"
@asymmetric asymmetric merged commit dc055c0 into nix-community:master Mar 24, 2023
@infinisil infinisil deleted the multiple-idents branch March 27, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants