-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos: Add assertion for persisting UIDs/GIDs #188
nixos: Add assertion for persisting UIDs/GIDs #188
Conversation
Gentle reminder @talyz. Do you in general like the idea of this PR? Do you think we could find someone to review this? The corresponding issue I opened (#178) did get attention from a couple other people as well, so it's clear that I was not the only person who ran into this issue, and this check would be useful to have. |
Looks really useful! Thanks! :) And sorry for the slow response! |
It should be possible for this to be skipped by some option 9de98e0#commitcomment-145532610 |
I feel this merge needs to be more aware. At least it needs to be documented. |
And we should check all possible parent directories, |
When parent directories like |
There should be a way to turn this off. |
9de98e038ae91e15ea725700386044309b340299 causes an evaluation failure. See nix-community/impermanence#188 for details.
Oops, yeah, didn't think of that. At least we got some quick feedback on this now (haha), but @talyz we should probably revert this as it's clearly breaking people's setups. I might have time in a few days to work on a fixup. From the comments above I gather that:
If anyone has additional ideas for how a future attempt at this could be improved, please leave a comment. |
This makes the assertion consider the legitimate case of any of /var/lib/nixos's parents being persisted. It also changes the assertion to a warning, as it's not critical to everyone. Fixes issues caused by #188.
Yep, I agree with all of this. I've pushed a few changes to solve this now:
|
Persist the '/var/lib/nixos' directory in order to perist UIDs/GIDs between boots. REF: nix-community/impermanence#188
Fixes #178