Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(buildPythonPackage): support new pyproject format #948

Merged
merged 2 commits into from
May 23, 2024

Conversation

yajo
Copy link
Contributor

@yajo yajo commented Apr 30, 2024

NixOS/nixpkgs#271597 implemented a new format for python packages that is starting to get traction in nixpkgs/unstable (soon to become NixOS 24.05).

That is a progress towards NixOS/nixpkgs#272178, which would be a massive improvement for dream2nix once completed.

This first step just makes sure that buildPythonPackage supports the new arguments properly. Without this change, many dream2nix python derivations fail to build on nixos-unstable right now.

Probably other python auto-builders should leverage these new options when available for the d2n user. That can be added later.

@moduon MT-1075

Copy link
Member

@phaer phaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Makes sense and changes look good to me :)

@yajo
Copy link
Contributor Author

yajo commented May 8, 2024

So, ready to merge?

@phaer
Copy link
Member

phaer commented May 11, 2024

So, ready to merge?
Thought so during my review, but lets see what @DavHau has to say about it :)

NixOS/nixpkgs#271597 implemented a new format for python packages that is starting to get traction in nixpkgs/unstable (soon to become NixOS 24.05).

That is a progress towards NixOS/nixpkgs#272178, which would be a massive improvement for dream2nix once completed.

This first step just makes sure that `buildPythonPackage` supports the new arguments properly. Without this change, many dream2nix python derivations fail to build on nixos-unstable right now.

Probably other python auto-builders should leverage these new options when available for the d2n user. That can be added later.

@moduon MT-1075
@yajo yajo force-pushed the python-pyproject-format branch from 0d9268c to 4cd8cbd Compare May 13, 2024 08:40
@phaer phaer merged commit e88ba85 into nix-community:main May 23, 2024
71 checks passed
@yajo yajo deleted the python-pyproject-format branch May 24, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants