Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Check that the checksum of a task doesn't change during execution #681

Open
tclose opened this issue Aug 2, 2023 · 0 comments
Open
Labels
maintenance Refactors and improvements to code quality.

Comments

@tclose
Copy link
Contributor

tclose commented Aug 2, 2023

If the checksum of a task changes during execution then Pydra won't know where to look for the results and bugs out with a cryptic message (NoneType doesn't have attribute ...). We should at least cache the checksum and detect when it has changed and provide a more descriptive error message. Ideally, we would store checksums for each of the input fields to help narrow down the issue in the error message.

For example, I had a task where the output directory was specified as type Directory instead of Path and therefore its hash changed after the output data was written to it. We should be able to catch this case and prompt the user to consider changing it to a path.

@tclose tclose added the maintenance Refactors and improvements to code quality. label Aug 2, 2023
@tclose tclose mentioned this issue Sep 11, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Refactors and improvements to code quality.
Projects
None yet
Development

No branches or pull requests

1 participant