Rename the project as Minipack #14
Merged
+204
−162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikushi
referenced
this pull request
May 29, 2019
That directory(namespace) should have been gone by https://github.com/nikushi/webpack_manifest/pull/14
nikushi
added a commit
that referenced
this pull request
May 29, 2019
Just a follow-up fix of #14. The spec files under rails directory should have been moved to the parent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I described in https://github.com/nikushi/webpack_manifest/issues/12 about the project naming. I want to rename the project.
Generally workflow of building assets related to server side includes:
Although at the moment I made WebpackManifest I just focused on resolving paths, there are some other tasks that this gem can help. It will not offer all the features above unlike Webpacker, but renaming the project is the right direction.