Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add a flag to transpileSchema to skip schema checks #39

Open
healqq opened this issue Oct 17, 2019 · 4 comments
Open

Comments

@healqq
Copy link

healqq commented Oct 17, 2019

Hello! I was trying to make type inheritance work in graphql and your library is perfect for this. There is just one small issue that doesn't let me use it out of the box: when I call transpileSchema - it runs some checks, for example this one: https://github.com/nicolasdao/graphql-s2s/blob/master/src/graphqls2s.js#L894. And it breaks in case of schema stiching.
In my pipeline I use .graphql files and I made a very simple loader:

const { transpileSchema } = require('graphql-s2s').graphqls2s;

module.exports = (source) => {
  const schema = transpileSchema(source);
  console.log(schema);
  return schema;
}

this runs before graphql-tag loader and it works just fine if I comment out those interface checks.
Would be nice if there was a flag that could ignore those checks if it's passed. I can probably contribute, but would be nice if you could point what other places should be affected by that flag.

@healqq healqq changed the title Feature request: add a flag to transpileSchema to skip schema cheks Feature request: add a flag to transpileSchema to skip schema checks Oct 17, 2019
@nicolasdao
Copy link
Owner

Thanks a lot for your feature request @healqq. We're glad to hear that you find our lib helpful.

We'll deal with your request asap.

Have a great weekend.

Cheers,

Nic

@nicolasdao
Copy link
Owner

Hi @healqq ,

Do you think you could give me some examples to recreate that issue? I need that example to build some unit tests and make sure all is ok.

Thanks.

Nic

@healqq
Copy link
Author

healqq commented Oct 23, 2019

@nicolasdao something like that should work:

// index.js
import { transpileSchema } from 'graphql-s2s';
const type = `
type Entity implements Identifiable {
  id: Int!
}
`;
// Should not throw an exception that Identifiable is not defined
const schema = transpileSchema(type);

@nicolasdao
Copy link
Owner

Awesome @healqq. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants