Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GraphQL draft syntax for multiple interface implementation. #28

Open
purplemana opened this issue Nov 13, 2018 · 2 comments
Open

Comments

@purplemana
Copy link

Per the spec, the multiple interface implementation syntax uses & instead of , as the separator, e.g.

type User implements Node & Paginated {

Currently graphql-s2s converts this to:

type User implements Node {

keeping only the first interface name.

An online repl is available here.

In addition to this, imho, the inherits syntax which is graphql-s2s specific, should also be changed to use & as name separator keeping both the syntax in harmony.

@nicolasdao
Copy link
Owner

Makes a lot of sense @purplemana. I agree with you.

I've added that to my list. I'll release that change with the next version of graphql-s2s.

Really appreciate you took the time to suggest that.

@greemo
Copy link

greemo commented Oct 8, 2021

Great, +1, the comma use for multiple implementation on the output schema breaks my automation flow, as I must manually convert the commas to &s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants