Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin static version in Dockerfile #4

Closed
nickrusso42518 opened this issue Jan 4, 2020 · 2 comments
Closed

Unpin static version in Dockerfile #4

nickrusso42518 opened this issue Jan 4, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@nickrusso42518
Copy link
Owner

ARG VERSION
FROM openjdk:8-jre-alpine
LABEL maintainer="njrusmc@gmail.com"

# Download the specific VTL release, unzip it, and delete the original zip.
RUN wget https://github.com/plavjanik/vtl-cli/releases/download/v${VERSION}/vtl.zip && \
    unzip vtl.zip && \
    rm -f vtl.zip

# Copy the sample directory into the container.
COPY sample /sample

VERSION=0.1.1 docker build --build-arg VERSION=$VERSION -t .../vtlcli:$VERSION .

@nickrusso42518 nickrusso42518 added the enhancement New feature or request label Jan 4, 2020
@nickrusso42518 nickrusso42518 self-assigned this Jan 4, 2020
@nickrusso42518
Copy link
Owner Author

@nickrusso42518
Copy link
Owner Author

Note ARG has to come after the FROM statement in this case, as the args get wiped out after the importation of the base image.

Reference: moby/moby#34129

nickrusso42518 pushed a commit that referenced this issue Jan 4, 2020
nickrusso42518 added a commit that referenced this issue Jan 4, 2020
nickrusso42518 pushed a commit that referenced this issue Jan 4, 2020
nickrusso42518 pushed a commit that referenced this issue Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant