-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug/Feature] Single map group compatibility issues #14
Comments
Hey @Geant200 , apologies on the delay in getting back to you, as I was out of town yesterday. Does this issue seem to only occur for the workshop map provided or do all workshop maps appear to be impacted? Also, does the issue only occur with the menu or does the following command work to change the map: !map assembly 1703278880 This will help me understand if the issue is with how my ChangeMap function is behaving or if its an issue with the way the map is being parsed. Additionally, it may help if you could provide any logs from the csgo/counterstrikesharp/logs folder during the time the issue is reproduced. The files will be prefixed with GameModeManager. Last thing, if this is a parsing issue, I would want to confirm that these workshop maps are defined in your gamemodes_server.txt file and associated with a specific map group. If so, I would want to see a snippet of where it is defined so that I can verify that file is formatted "properly". Happy to assist with the collection of this data if needed as well. My discord is striker.nick |
Good morning. Thank you for taking your time to help me ^^. So for the configuration of my gamemodes_server.txt file it's good. But I have problems with the RockTheVote plugin when I activate the RTV option I can no longer open the following management menu (!admin! css_admin !maps). When I activate this option no more menu.
Another thing when I have the voting option activated I am not all the workshop cards in the listing when the players have to make the choice for the next card. GameModeManager.json file
My cycle maps work well thanks to the gamemodes_server.txt file.
Before I used the SourceMode and ManiAdminPlugin and EventScripts plugins to manage my Counter Strike Source game servers, now the management of plugins is less pleasant to manage and configure on Counter Strike 2, a shame that this plugin is no longer functional. But thank you for giving us an alternative solution to manage the servers ^^. |
Hey @Geant200, thank you for providing this information. At the moment, I am not quite sure what might be causing issues with SimpleAdmin, but I would like to first address some of the other issues to see if they play a role in this. First, you will need a map group for each game mode in your gamemodes_server.txt rather than just using mg_perso. This is so that the correct maps are populated into the map menus for each game mode. For some context, when a game mode is launched, it will try to launch the game mode based on the configuration. For example, in the Game Mode List, you have an entry like so:
This will display the friendly name 'Competitive', but will run
It will then update all the map lists and map menus with the maps associated with that map group and will update the Maplist.txt with just the maps from that current map group. I think once this is configured, you will no longer experience this behavior. Please let me know how it goes! |
Thanks for the info but if I use the group. If I leave the server in Competitive mode it will remain in gaming mode. |
Hey @Geant200, if an RTV plugin is being used, it should handle map rotations such that the map will change to a map within the current map group/game mode. Unfortunately, mapgroups/game modes will not change in that scenario unless a user joins the server and votes for it (if voting for game modes is enabled) or an admin changes the game mode. If RTV is disabled, map rotations will occur as expected and every x map change (based on the config) it will change the game mode. Unfortunately, you cannot use both at the current time. |
With the help of the Map Configurator plugin we can tell it to execute .CFG files but I know if it is compatible with the Workshop maps?. |
@Geant200 , you are right and yes it does support Workshop maps. Technically speaking, a single map group should still display maps properly, but the !currentmode command will display incorrectly because it uses the map group name. However, I already have ideas of fixing this. I wonder if its the shear size of maps that you have. Would you be able to provide a copy of the logs? I can also see if I can recreate this on my end as well. Either way, now that you brought this configuration to my attention, I will work to make this plugin even more compatible with the use of a single map group, rather than just the original intention of having a mapgroup per game mode, which was really just done to simplfy things during the initial plugin creation phase. |
If we can make the system easier that would be great ^^. log-all20240620.txt |
@Geant200 , I almost have a new version completed with better compatibility for single map groups. Regarding your specific issue, it seems like it may be related to the number of maps in the map group: 2024-06-20 15:40:21.161 +02:00 [WARN] (cssharp:Core) Display should not be longer than 26 characters for a CenterHtmlMenu item Would you be able to change MapGroup.Style to Chat instead of Center to see if that yields the same behavior? "MapGroup": { I am guessing that it will work and if so, it's a limitation with the CounterStrikeSharp library for CenterHTMLMenus and you will have to use the ChatMenu instead. Unfortunately, there aren't any other menu types at the moment, but I also too miss the old radio button menus. Hopefully they will bring them back soon! |
The change for the MapGroup.Style variable is in the GameModeManager.json file?. |
Yes, in the JSON file. It is normal game chat. I am cooking up a potential workaround in the event you want to continue to use the center html menu. I will let you know once it's ready and will post a pre-release for you to test. |
if I understood correctly in the GameModeManager.json file I mify as follows. Before
After
??. |
No, replace "center" with "chat" where it says: "Style": "center", |
I tested with the modification if I leave the modification the !maps menu no longer works and at the end of the game it offers me more voting choices it considers that the vote is null and applies a map to the hazards and when I !rtv I have the official maps but not the workshop one. |
Hello, I am still doing my configuration tests.
log-all20240622.txt |
Hey @Geant200 , after further review and testing with your exact configuration, I was able to confirm that your map group has too many maps. There is a limit of 105 maps in a single menu and this is why you are having issues. Please reduce your map group(s) to under this ammount. Additionally, I have added support for multiple map groups per game modes. Unforuntately, this is still confined by the above limitation, but you can add up to 105 maps total accross the map groups for a single game mode. This way, you could theoretically see all the maps available by switching the game mode just once or twice versus having to cycle through all game modes to identify their maps. Unfortunately, this is the best solution I can offer at the moment. If a better solution comes around, I will surely implement it. I will be marking this issue as completed. |
@Geant200 , just to add to this. There are now the following commands: !allmaps !showallmaps These commands will display maps from all map groups, but you will have to select the game mode first. Therefore, if you split up your single map group into multiple map groups per game mode, you will still be able to access all of the maps as a player or an admin depending on your configuration. I hope this helps! Keep a lookout for the latest release. |
Thank you for your time for responding to my request. But if I make several groups my cylce map will always be on the same map group and my server will never run on the other maps of the other groups automatically unless I manipulate the group change with a command to change each time I want to play a particular game mode. Would it be possible to ensure that in the mapcycle.txt file or another configuration file that the server map cycle faces rotate the groups of maps instead of the maps like that would be the same as a maps cycle but with groups that follow. I can ask you why a limit of 105 maps per group? I remember when I was configuring servers in CSS with the Metamod SourceMode Eventscript ManiAdminPlugin plugin I could place more cards it would be possible for you to use the same principle sorry I am not developed to the point of being able to create a plugin ^^. Thank you in advance ^^. |
@Geant200 , the limitation derives from the CounterStrikeSharp library so there is not too much I can do about it without diving into a custom solution. Regarding your question about map cycles, you are correct in stating that the map cycle will still only cycle maps within the current game mode, especially if using RTV. If you disable RTV, users can still create per-map votes or game mode votes, but the map rotation will also change the game mode every x map changes/rotations depending on what you set in the JSON configuration file. This sounds like it may suite your needs, but please let me know otherwise. We could potentially add all maps to the RTV map list, but that may result in the same error message regarding the menu limit, which is why many RTV plugins limit the ammount of maps in the RTV list and pick them at random. If that is the desired behavior (with a limited but random number of maps for RTV), then I can surely build something into the plugin to allow adding all maps to the RTV map list, if desired. |
My idea of making a Group maps cycle like a Maps cycle to ensure that the group of maps rotates would be good? like this all the maps of each group would rotate without overloading the group of maps. An example in my Cycle Group I would have 5 groups of 20 maps and the configuration file which would be called for example groupecycle.txt which would rotate the groups of maps as if it were a cycle of maps with this method all the maps forays run normally without the intervention of an admin it is possible for you to modify the plugin in this way I do not know coding to create this method ^^. I don't know if this is crazy or a good idea? ^^. |
@Geant200 , I think that is actually a really good idea and is definitely feasible. Let me see what I can do :) |
Many thanks in advance for your support ^^. |
@Geant200 , I made a commit that should allow the use of game mode schedules. In the config, you can specify a time that you want to schedule a mode change and then specify the mode. If the mode has multiple map groups, then it will rotate through the maps for that game mode. I haven't made a release yet and will be testing it out in the coming days, but thought I would share the update. |
Thanks again for the work, let me know when it's available ^^. |
@Geant200 you are very welcome! I am going on vacation soon so if I don't get to it before this Saturday you should see an update early July. Also, thanks for providing your feedback, it's been really helpful! |
I thank you if the community can help ^^. And have a good holiday ^^. |
@Geant200, I get what you mean. I added a new command called Map Cycle that can be set to 0, 1 or 2 0 = The plugin will rotate maps based on the maps from the current mode This rotation requires RTV to not be in use. Additionally, you can also enable Game Mode rotations to rotate the mode every X map changes. Lastly, I have the mode schedules as I mentioned previously, where you can schedule the mode to be changed at specific times of the day. I believe all these different options should suffice, please let me know otherwise. A release may come by the end of the week. |
Thank you again for making this modification when it is available I will test it directly ^^. |
@Geant200, a new release has been made! Let me know if you have any questions :) |
A big thank you, I will test this new version and I will give you some news ^^. |
Hello, I have completed the plugin configuration files. I can clearly see the map in the menu when I type the !maps command but when I validate the map which comes from the Workshop, it does not launch?.
Workshop map
Assembly https://steamcommunity.com/sharedfiles/filedetails/?id=3071005299
Plugin liste.
counterstrikesharp
metamod
CS2-CustomVotes
CS2-SimpleAdmin
CS2-Tags
GameModeManager
Map_Configs_Prefix
RockTheVote
Maps Liste
maplist.txt csgo\addons/counterstrikesharp/plugins/RockTheVote/maplist.txt
Configuration
GameModeManager csgo\addons\counterstrikesharp\configs\plugins\GameModeManager
CS2-SimpleAdmin \csgo\addons\counterstrikesharp\configs\plugins\CS2-SimpleAdmin
RockTheVote \csgo\addons\counterstrikesharp\configs\plugins\RockTheVote
Can you help me?
I thank you in advance.
The text was updated successfully, but these errors were encountered: