Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spawn not exec to run commands #88

Merged
merged 4 commits into from
Aug 4, 2022
Merged

Conversation

nick-fields
Copy link
Owner

@nick-fields nick-fields commented Aug 4, 2022

As a possible fix for #84 and #76, use spawn rather than exec to run commands after @tstackhouse found that exec wasn't great at handling large outputs due to its use of buffering. Spawn is much more efficient because it streams output.

Tested this locally with 1000MiB of output using @LukeShu very helpful repro script and after a very long wait, it exited as expected. Added a test of 100MiB to CI to ensure this continues working.

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #88 (b4ef326) into master (a25f198) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master     #88   +/-   ##
======================================
  Coverage    1.38%   1.38%           
======================================
  Files           2       2           
  Lines         144     144           
  Branches       48      48           
======================================
  Hits            2       2           
  Misses        131     131           
  Partials       11      11           

@nick-fields nick-fields changed the title test: try to repro #84 Use spawn not exec to run commands Aug 4, 2022
@nick-fields nick-fields marked this pull request as ready for review August 4, 2022 03:01
@nick-fields nick-fields merged commit 616fa81 into master Aug 4, 2022
@nick-fields nick-fields deleted the nrf/pass-thru-env branch August 4, 2022 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants