examples: Check for DAQmx event registration errors #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
commented
May 18, 2023
bkeryan
commented
May 18, 2023
bkeryan
commented
May 18, 2023
|
daqmx is still the only driver that's excluded from the Note that script can also run the examples if you run it locally with a "server url" param. No action required, just pointing out a helpful tool that's not helping here. |
astarche
approved these changes
May 18, 2023
reckenro
approved these changes
May 18, 2023
Base automatically changed from
users/bkeryan/nidaqmx-threaded-event-example
to
main
May 19, 2023 11:44
I got |
Signed-off-by: Brad Keryan <brad.keryan@ni.com>
- Extract a check_for_stream_error function. - For non-aio, use stream.exception() to check for errors - For aio, use stream.code() to check for errors because the aio interfaces don't support stream.exception() Signed-off-by: Brad Keryan <brad.keryan@ni.com>
bkeryan
force-pushed
the
users/bkeryan/nidaqmx-event-example-registration-errors
branch
from
782dab1
to
5fc9c53
Compare
bkeryan
commented
May 23, 2023
grpc-stubs doesn't treat the object returned from a UnaryStreamMultiCallable as a Future. shabbyrobe/grpc-stubs#41 Signed-off-by: Brad Keryan <brad.keryan@ni.com>
bkeryan
deleted the
users/bkeryan/nidaqmx-event-example-registration-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Change the DAQmx event examples to explicitly check for stream errors after waiting for initial metadata.
If the stream was closed with an error, it is "done" and reading a response will throw an exception.
Why should this Pull Request be merged?
Demonstrates how to benefit from #927
What testing has been done?
Tested examples as written.
Tested error handling by changing
EVERY_N_SAMPLES_EVENT_TYPE_ACQUIRED_INTO_BUFFERtoEVERY_N_SAMPLES_EVENT_TYPE_TRANSFERRED_FROM_BUFFERand adding areturnafter the error check to prevent the worker thread/async task from being started.