New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RFSG attenuation example #888

Merged

shastriUF merged 29 commits into main from users/gorozco/attenuationexample

Jun 23, 2023

Contributor

yardov commented Mar 20, 2023 •

edited by astarche

Loading

What does this Pull Request accomplish?

New example that would help customers navigate how to convert attenuation tables to s-parameters and how they are used in RFSG

Why should this Pull Request be merged?

These concepts are tricky in RFSG and given this is a new no one to one map with C, is hard to get this right in the first attempt.

What testing has been done?

Based on the single tone example, and only adding these attenuation table definition.

Gerardo Orozco added 16 commits

February 1, 2023 11:36


          New example showing user download waveform.

775cef4


          Python style with ni-python-styleguide.

758a71d


          second attempt to validte ni-python-styliguides

a3c1f8b


          Still trying to format based on the output of the pipeline.

c4c387f


          I will keep trying to make formatting changes

ef986c8


          Using online black checker I think I know the form

be66e00


          Fixing D401

f0cfb47


          BLK100 Fix

a357db6


          using black online to fix this formatting.

748edf7


          Black formatting

5808ab9


          Trying Black with 95 lengh

9fcb4fa


          Used Brad feedback to know is 100 character line.

5839e52


          fixed datatype assignment

b04322a


          Fixing all suggested edits and trying signing

7159db4

Signed-off-by: Gerardo Orozco <gorozco@ni.com>


          New example to show how to use attenuation tables in rfsg

cbe956c


          Example to show how to use att tables with RFSG

9aee35a

yardov requested review from astarche and reckenro as code owners

March 20, 2023 20:25


          Changed math into standard group of imports.

a6c9f28

reckenro reviewed

View reviewed changes

nidevice_pb2.py Outdated Show resolved Hide resolved

reckenro reviewed

View reviewed changes

examples/nirfsg/attenuation-tables-generation.py Outdated Show resolved Hide resolved

reckenro reviewed

View reviewed changes

examples/nirfsg/rfsg-multitone-example.py Outdated Show resolved Hide resolved

reckenro reviewed

View reviewed changes

examples/nirfsg/attenuation-tables-generation.py Show resolved Hide resolved

reckenro reviewed

View reviewed changes

examples/nirfsg/attenuation-tables-generation.py Outdated Show resolved Hide resolved

yardov and others added 6 commits

March 20, 2023 20:05


          Update examples/nirfsg/attenuation-tables-generation.py

0b1e325

Co-authored-by: Ryan Eckenrode <77176215+reckenro@users.noreply.github.com>


          Delete nidevice_pb2.py

92148c2


          Delete nidevice_pb2_grpc.py

1d4bab9


          Delete session_pb2_grpc.py

b2ed7c6


          Delete session_pb2.py

b55d6aa


          matching the other examples error handling

fe3a961

Gerardo Orozco added 3 commits

March 20, 2023 21:08


          Merge branch 'users/gorozco/attenuationexample' of https://github.com…

12a0f20

…/ni/grpc-device into users/gorozco/attenuationexample


          Merge remote-tracking branch 'origin/main' into users/gorozco/attenua…

b81e803

…tionexample


          Merge branch 'users/gorozco/attenuationexample' of https://github.com…

9edb661

…/ni/grpc-device into users/gorozco/attenuationexample

astarche changed the title ~~Users/gorozco/attenuationexample~~ Add RFSG attenuation example

astarche approved these changes

View reviewed changes

examples/nirfsg/attenuation-tables-generation.py Outdated Show resolved Hide resolved


          changed S12 to S variable. Added the -X sign

5516f7d

reckenro reviewed

View reviewed changes

examples/nirfsg/attenuation-tables-generation.py Outdated Show resolved Hide resolved

yardov and others added 2 commits

March 22, 2023 14:40


          Update examples/nirfsg/attenuation-tables-generation.py

baa2fef

Co-authored-by: astarche <56981669+astarche@users.noreply.github.com>


          Update examples/nirfsg/attenuation-tables-generation.py

da7e5e2

Co-authored-by: Ryan Eckenrode <77176215+reckenro@users.noreply.github.com>

reckenro requested changes

View reviewed changes

Collaborator

reckenro left a comment

We're in the process of making the 2.1 release and I don't want anything going into main until we've bumped the exports from main to be 2.2. I'll reset myself and approve after the export version is bumped (should be in a day or so).

reckenro self-requested a review

March 29, 2023 15:42

reckenro approved these changes

View reviewed changes

shastriUF merged commit 562c99a into main

shastriUF deleted the users/gorozco/attenuationexample branch

June 23, 2023 15:43

shastriUF mentioned this pull request

Use supported operand types by casting to string instead of Optional[str] #954

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet