Update niRFmxLTE to 23.0 #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WesleyTangNationalInstruments
requested review from
reckenro and
astarche
as code owners
WesleyTangNationalInstruments
changed the title
reckenro
reviewed
Feb 16, 2023
reckenro
requested changes
Feb 16, 2023
astarche
approved these changes
Feb 22, 2023
reckenro
approved these changes
Feb 22, 2023
WesleyTangNationalInstruments
deleted the
users/wetang/UpdateRFmxLTETo23_0
branch
reckenro
added
the
source-breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Updates niRFmxLTE support to 23.0 API. Metadata files were sourced from
grpc-device-scrapigen(see this PR).The adds the following:
Enums
SemUplinkMaskTypeSEM_UPLINK_MASK_TYPE_NS28,SEM_UPLINK_MASK_TYPE_CANS09,SEM_UPLINK_MASK_TYPE_CANS10SEM_UPLINK_MASK_TYPE_NS27was changed toSEM_UPLINK_MASK_TYPE_NS27_OR_NS43MODACC_SYMBOL_CLOCK_ERROR_ESTIMATION_ENABLEDMODACC_PRE_FFT_ERROR_ESTIMATION_INTERVALMODACC_TIMING_TRACKING_ENABLEDMODACC_PHASE_TRACKING_ENABLEDAttributes
MODACC_RESULTS_MAXIMUM_PEAK_IQ_ORIGIN_OFFSETMODACC_PRE_FFT_ERROR_ESTIMATION_INTERVALMODACC_SYMBOL_CLOCK_ERROR_ESTIMATION_ENABLEDMODACC_TIMING_TRACKING_ENABLEDMODACC_PHASE_TRACKING_ENABLEDMODACC_RESULTS_MAXIMUM_PEAK_FREQUENCY_ERRORWhy should this Pull Request be merged?
AB#2299243
What testing has been done?
Build passes.