Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Updates the niRFmxNR service to the latest public API (version 22.5). New functions, attributes, and enums were added.
Breaking changes:
RFMXNR_ATTR_MODACC_PHASE_TRACKING_ENABLED
attribute has been replaced byRFMXNR_ATTR_MODACC_PHASE_TRACKING_MODE
RFMXNR_ATTR_MODACC_TIMING_TRACKING_ENABLED
attribute has been replaced byRFMXNR_ATTR_MODACC_TIMING_TRACKING_MODE
These accommodate new enum values:
NIRFMXNR_INT32_MODACC_PHASE_TRACKING_MODE_DISABLED = 0
NIRFMXNR_INT32_MODACC_PHASE_TRACKING_MODE_REFERENCE_AND_DATA = 1
NIRFMXNR_INT32_MODACC_PHASE_TRACKING_MODE_PTRS = 2
NIRFMXNR_INT32_MODACC_TIMING_TRACKING_MODE_DISABLED = 0
NIRFMXNR_INT32_MODACC_TIMING_TRACKING_MODE_REFERENCE_AND_DATA = 1
While the following enums have been removed:
NIRFMXNR_INT32_MODACC_PHASE_TRACKING_ENABLED_FALSE = 0
NIRFMXNR_INT32_MODACC_PHASE_TRACKING_ENABLED_TRUE = 1
NIRFMXNR_INT32_MODACC_TIMING_TRACKING_ENABLED_FALSE = 0
NIRFMXNR_INT32_MODACC_TIMING_TRACKING_ENABLED_TRUE = 1
Existing source code wishing to compile against the updated
nirfmxnr.proto
will need to update references to modulation accuracy phase tracking and timing tracking to use the new_MODE
attributes, but existing binaries should work.I updated calls in the driver API tests to reflect these changes as well.
Why should this Pull Request be merged?
To support applications under development that use grpc and the latest version of RFmx.
What testing has been done?
Built and ran tests. All system tests passed, except two that always fail on my test machine, and one that doesn't seem related to NR changes: