Fix function name for FPGA in LibraryLoadException #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amehra-ni
requested review from
reckenro,
astarche and
maxxboehme
as code owners
maxxboehme
approved these changes
Aug 27, 2024
reckenro
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
See Rohan's comment here.
Previously, we introduced a new parameter, c_dll_function_prefix, for FPGA because the function names in the header file did not match those in the DLL for FPGA. In the DLL, the functions are named NiFpgaDll_Open, whereas in the header file, they are named NiFpga_Open. Rohan mentioned that we should also update the function names in the LibraryLoadException message. This PR accomplishes that.
Why should this Pull Request be merged?
Updated the cname to use c_dll_function_prefix as it will contain the DLL prefix or the normal C prefix.
What testing has been done?