Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPGA read/write APIs. #1074

Merged
merged 3 commits into from
Aug 6, 2024
Merged

FPGA read/write APIs. #1074

merged 3 commits into from
Aug 6, 2024

Conversation

amehra-ni
Copy link
Contributor

@amehra-ni amehra-ni commented Jul 31, 2024

What does this Pull Request accomplish?

This PR contains code generation for Read/Write FPGA functions.

Why should this Pull Request be merged?

  • Update config.py files so the new data type can map correctly.
  • Added a few more narrow types in KNOWN_COERCED_NARROW_NUMERIC_TYPES.

What testing has been done?

  • No compile or codegen issues.
  • Manually verified server handlers for all APIs and compared them with documentation for the APIs mentioned.
  • Manually tested Read/Write(normal), Read/Write(array), Read(Fifo) with client code which calls the functions correctly and data is as expected. In the process of testing Write(Fifo).

@amehra-ni amehra-ni marked this pull request as ready for review August 2, 2024 11:05
@amehra-ni amehra-ni self-assigned this Aug 6, 2024
@amehra-ni amehra-ni merged commit 9f32d64 into main Aug 6, 2024
10 of 11 checks passed
@amehra-ni amehra-ni deleted the users/amehra/read-write-functions branch August 6, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants