Use new action to download ninja #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Use a github action that is more recently updated to download ninja and add to path so cmake can find it.
seanmiddleditch/gha-setup-ninja. Project and dependencies appear to be updated as of 3 weeks ago and it specifies using Node.js 20.
The code is very straight forward and is all in one file currently. It performs the same operations of the previous action, using the github url to download the released version of ninja to the system and then adds it to the path to be referenced in later steps.
Why should this Pull Request be merged?
The current action being used uses Node.js 16 which github is planning to deprecate in the future.
What testing has been done?