-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated grpc device code for ModSpectrum APIs and Attributes #1037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as on the corresponding scrapigen PR: Is this to match an upcoming RFmx BT release? Typically we bump the metadata to match a new version of the API (see last bump to 24.0).
And if so, you'll want to update the version in config.py and the README to be up to date.
This will match the Upcoming RFmx 24.3 BT Release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. FYI there's a Bug right now preventing submission in the repo (it's what's causing the validate_python step to fail). You'll have to wait for that to go in before getting a passing build and ability to merge.
Update: That bug was fixed but I think you'll have to merge main to get those fixes into this branch and the CI build to pass.
…aitipam/ModSpectrum_GrpcDeviceCode
The Python Validation step is now passed Successfully. Looks like the CI/build_desktop/Windows Build Required step failed. |
Oh sorry, I should've mentioned this when you updated |
@maxxboehme Can you review this PR as this PR is being hold from long time because your review is pending on this |
What does this Pull Request accomplish?
Updates niRFmxBT in grpc-device to 24.3
Updates the Grpc Device Code for Mod spectrum APIs and attributes.
Updates the Grpc Device Code for Channelsoundingsyncsequence attribute enum update to payload pattern
Why should this Pull Request be merged?
Updated to match the upcoming release of niRFmxBt 24.3.0
What testing has been done?
Manually inspected generated files..
Manually inspected nirfmxbluetooth.proto file