Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated grpc device code for ModSpectrum APIs and Attributes #1037

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

Udeepchandra
Copy link
Contributor

@Udeepchandra Udeepchandra commented Jan 30, 2024

What does this Pull Request accomplish?
Updates niRFmxBT in grpc-device to 24.3
Updates the Grpc Device Code for Mod spectrum APIs and attributes.
Updates the Grpc Device Code for Channelsoundingsyncsequence attribute enum update to payload pattern

Why should this Pull Request be merged?
Updated to match the upcoming release of niRFmxBt 24.3.0

What testing has been done?
Manually inspected generated files..
Manually inspected nirfmxbluetooth.proto file

Copy link
Collaborator

@reckenro reckenro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as on the corresponding scrapigen PR: Is this to match an upcoming RFmx BT release? Typically we bump the metadata to match a new version of the API (see last bump to 24.0).

And if so, you'll want to update the version in config.py and the README to be up to date.

@Udeepchandra
Copy link
Contributor Author

This will match the Upcoming RFmx 24.3 BT Release.

Copy link
Collaborator

@reckenro reckenro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update config.py and the README to bump the RFmx BT version to 24.3?

@Udeepchandra
Copy link
Contributor Author

Can you update config.py and the README to bump the RFmx BT version to 24.3?

Updated the Version.

Copy link
Collaborator

@reckenro reckenro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. FYI there's a Bug right now preventing submission in the repo (it's what's causing the validate_python step to fail). You'll have to wait for that to go in before getting a passing build and ability to merge.

Update: That bug was fixed but I think you'll have to merge main to get those fixes into this branch and the CI build to pass.

@Udeepchandra
Copy link
Contributor Author

Looks good. FYI there's a Bug right now preventing submission in the repo (it's what's causing the validate_python step to fail). You'll have to wait for that to go in before getting a passing build and ability to merge.

Update: That bug was fixed but I think you'll have to merge main to get those fixes into this branch and the CI build to pass.

Looks good. FYI there's a Bug right now preventing submission in the repo (it's what's causing the validate_python step to fail). You'll have to wait for that to go in before getting a passing build and ability to merge.

Update: That bug was fixed but I think you'll have to merge main to get those fixes into this branch and the CI build to pass.

The Python Validation step is now passed Successfully. Looks like the CI/build_desktop/Windows Build Required step failed.

@reckenro
Copy link
Collaborator

reckenro commented Feb 8, 2024

The Python Validation step is now passed Successfully. Looks like the CI/build_desktop/Windows Build Required step failed.

Oh sorry, I should've mentioned this when you updated config.py. It'll cause the .proto to be updated with that new version at the top of the file. So you'll need to rebuild locally and push up the changed .proto file so the build doesn't complain about a mismatch between what's in the branch's generated folder and what the CI build produces.

@Udeepchandra
Copy link
Contributor Author

@maxxboehme Can you review this PR as this PR is being hold from long time because your review is pending on this

@maxxboehme maxxboehme merged commit 4bd9618 into main Feb 15, 2024
11 checks passed
@maxxboehme maxxboehme deleted the users/uaitipam/ModSpectrum_GrpcDeviceCode branch February 15, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants